androidx.navigation.dynamicfeatures.fragment.ui.AbstractProgressFragment navigate multiple time [169636207]

Fixed

Bug

Status Update

No update yet.

Description

pq...@gmail.com

created issue #1

Sep 30, 2020 04:14AM

Component used: androidx.navigation:navigation-dynamic-features-fragment

Version used:2.3.0 Devices/Android versions reproduced on: all devices/android versions

override fun onResume() { super.onResume() if (navigated) { findNavController().popBackStack() return } var monitor = installViewModel.installMonitor if (monitor == null) { Log.i(TAG, "onResume: monitor is null, navigating") navigate() monitor = installViewModel.installMonitor } if (monitor != null) { Log.i(TAG, "onResume: monitor is now not null, observing") monitor.status.observe(this, StateObserver(monitor)) } }

Any time onResume() is called, monitor.status observed. When dynamic feature module is installed, each StateObserver will call navigate() and destination activity/fragment will be navigated multiple time

Comments

jb...@google.com <jb...@google.com> Oct 2, 2020 07:20PM

Assigned to be...@google.com.

be...@google.com <be...@google.com> #2Oct 5, 2020 03:18PM

Great

ap...@google.com <ap...@google.com> #3Nov 4, 2020 06:40PM

Project: platform/frameworks/support
Branch: androidx-main

commit a735aaa4d06c90454de772fae5a02f6cbde210b3
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 28 22:58:23 2023

Ensure FragmentNavigator destroys intermediate entries on popUpTo

We need to make sure that when Fragment are destroyed their entries are
also always destroyed.

RelNote: "Fixes a regressions in previous release that caused the wrong
BottomNav menu item to be highlighted when using system back to go
between tabs."
Test: Added FragmentNavigatorTest
Bug: 270447657

Change-Id: I634f6047b7016bcb8b690047605a6f66b2dc1438

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2461556

il...@google.com <il...@google.com> #4Nov 4, 2020 07:14PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.6.0-alpha07 release.

b9...@gmail.com <b9...@gmail.com> #5Dec 14, 2020 05:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023

Add FragmentNavigator test to assert entry destroyed

Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.

Asserts that the fix on this bug also fixes

b/270610768

.

Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt

https://android-review.googlesource.com/2464422

be...@google.com <be...@google.com> #6Dec 14, 2020 05:58PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

b9...@gmail.com <b9...@gmail.com> #7Dec 14, 2020 07:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7cf55857f0db6bd1a1e1f95be7374ed5cf3eca58
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 15 16:59:50 2023

Fix system back after popUpTo

After you do a popUpTo inclusive while using Navigation with Fragments,
if you attempt to do a system back call, the Navigation back stack is
never updated.

The reason for this is that when fragment views are DESTROYED, we need
for the observer in the FragmentNavigator to update the state so we know
that the entry was already popped.

RelNote: "When using system back after doing a navigate with popUpTo,
the state of the NavController will pop to the correct entry."
Test: Added OnBackPressedTest
Bug: 270447657

Change-Id: I3a8ec072ba6d1655ab054cc081961825909088e6

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/OnBackPressedTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2493203

b9...@gmail.com <b9...@gmail.com> #8Dec 14, 2020 07:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha08

ap...@google.com <ap...@google.com> #9Dec 15, 2020 05:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 524a4f074b688975041f6ddd9db9eb31a88410e8
Author: Ben Weiss <benweiss@google.com>
Date: Tue Dec 15 12:26:06 2020

Add missing onViewCreated call

DefaultProgressFragment did not call super.onViewCreated which
could lead to installation progress not completing.

Bug: 169636207
Test: N/A
RelNote: Fix stuck installation progress
Change-Id: Ib27a77bc4572fc69cea38d738255c987449d6137

M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/DefaultProgressFragment.kt

https://android-review.googlesource.com/1529306

b9...@gmail.com <b9...@gmail.com> #10Feb 4, 2021 04:07PM

Why this fix doesn't included in 2.3.3?

il...@google.com <il...@google.com> #11Feb 10, 2021 01:03AM

Re #10, yes, you're right this didn't make it into Navigation 2.3.3. Sorry about that. We'll look at doing a Navigation 2.3.4 with this fix.

b9...@gmail.com <b9...@gmail.com> #12Mar 6, 2021 03:47PM

#11 Still no 2.3.4 released.

za...@gmail.com <za...@gmail.com> #13Jul 4, 2022 02:51PM

I believe I'm facing another issue because of this fix:

When navigating to an activity that belongs to a dynamic module, the AbstractProgressFragment is not removed from the back stack. The line that's supposed to do it was moved from onResume to onViewCreated:

if (navigated) {
    findNavController().popBackStack()
    return
}

And onViewCreated is not called since we're coming back from another activity.

Moving that block back to the onResume method should solve the problem. In the meantime (as a workaround), I guess we can do as follows:

class CustomProgressFragment : AbstractProgressFragment() {

    private var navigated = false

    override fun onResume() {
        super.onResume()
        // Workaround:
        // AbstractProgressFragment is not being removed from the back stack when returning from another activity
        if (navigated) findNavController().popBackStack()
    }

    override fun onInstalled() {
        testing = true
    }
   
   ...
   ...
}

za...@gmail.com <za...@gmail.com> #14Jul 4, 2022 02:54PM

Update: Regarding the workaround I mentioned, this is the correct implementation of the onInstalled method

    override fun onInstalled() {
        navigated = true
    }

il...@google.com <il...@google.com> #15Jul 13, 2022 11:18PM

Re comment#13 - please file a separate bug with a sample project that reproduces your issue. onViewCreated() is indeed called when you return to the AbstractProgressFragment from another fragment, which is the only thing your newly loaded graph should have as its start destination. You...don't happen to have a start destination that is an activity destination? You shouldn't be using Dynamic Navigation at all in that case (as the system will auto-download the module your activity is in upon request).