IssueTracker

yeah, looks like a bug.

I look closer and now I'm not sure what is the best behavior. Currently keys() does what javadoc says "all keys contained in this SavedStateHandle". Technically, before first onSaveInstanceState keys corresponding to SavedStateProviders aren't in the SavedStateHandle. However I can see, that SavedStateProvide is kinda promise that value will be in the SavedStateHandle in future.

I think we can do smth like:

fun keys() = mRegular.keySet() + mSavedStateProviders.keySet()

Ian, what do you think?

Yes, I think having keys() return the combined set as recommended in comment#3 makes a lot of sense and ensures that the set of keys is the same both before and after the state is actually saved.

onViewCreated on Fragment is a GNDN function, so no need to override it.

Can you provide more information as to how your installation won't execute?

Move install monitor observation to onViewCreated

DefaultProgressFragment won't execute super(AbstractProgressFragment)'s onViewCreated(). So after this change, DefaultProgressFragment can't monitor the installation progress.

TL;DR

Call super.onViewCreated(view, savedInstanceState) in DefaultProgressFragment will solve this issue.

Why this fix doesn't included in 2.3.3?

Re #10, yes, you're right this didn't make it into Navigation 2.3.3. Sorry about that. We'll look at doing a Navigation 2.3.4 with this fix.

I believe I'm facing another issue because of this fix:

When navigating to an activity that belongs to a dynamic module, the AbstractProgressFragment is not removed from the back stack. The line that's supposed to do it was moved from onResume to onViewCreated:

if (navigated) {
    findNavController().popBackStack()
    return
}

And onViewCreated is not called since we're coming back from another activity.

Moving that block back to the onResume method should solve the problem. In the meantime (as a workaround), I guess we can do as follows:

class CustomProgressFragment : AbstractProgressFragment() {

    private var navigated = false

    override fun onResume() {
        super.onResume()
        // Workaround:
        // AbstractProgressFragment is not being removed from the back stack when returning from another activity
        if (navigated) findNavController().popBackStack()
    }

    override fun onInstalled() {
        testing = true
    }
   
   ...
   ...
}

Update: Regarding the workaround I mentioned, this is the correct implementation of the onInstalled method

    override fun onInstalled() {
        navigated = true
    }

Re comment#13 - please file a separate bug with a sample project that reproduces your issue. onViewCreated() is indeed called when you return to the AbstractProgressFragment from another fragment, which is the only thing your newly loaded graph should have as its start destination. You...don't happen to have a start destination that is an activity destination? You shouldn't be using Dynamic Navigation at all in that case (as the system will auto-download the module your activity is in upon request).