Add lint warning for calling LayoutInflater.from() in onCreateDialog() [170781346]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Oct 14, 2020 07:13AM

When using a DialogFragment, if you want to get a LayoutInflater, you should always call the getLayoutInflater() method from Fragment.

Using LayoutInflater.from(Context) can return a LayoutInflater that does not have the correct theme.

It would be nice if there was a lint rule, that caught all calls to LayoutInflater.from(Context) and suggested to use getLayoutInflater() instead.

Comments

su...@gmail.com <su...@gmail.com> #2Oct 15, 2020 05:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit cb3b96b2858feed4b2289b7281aff9d1b7831aba
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Wed Mar 03 23:36:49 2021

[GH] [FragmentStrictMode] Detect calls to Fragment#setUserVisibleHint

## Proposed Changes

- Detect calls to `Fragment#setUserVisibleHint`

## Testing

Test: See `FragmentStrictModeTest#detectSetUserVisibleHint`

## Issues Fixed

Fixes: 153738974

This is an imported pull request from

https://github.com/androidx/androidx/pull/136.

Resolves #136
Github-Pr-Head-Sha: 0e253b7d7f9fc6e5cfe850a339605865c7f38384
GitOrigin-RevId: 5695bed064b7d0d34bf92ae57627fc0a2a709ae6
Change-Id: I17aaf805a09827c5ffeb888ded3fbb99560c49f3

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.java

https://android-review.googlesource.com/1616690

su...@gmail.com <su...@gmail.com> #3Oct 16, 2020 05:49AM

Hey, any help on how can I proceed forward.?

il...@google.com <il...@google.com> #4Oct 16, 2020 02:50PM

Assigned to jb...@google.com.

Re #2,3 - We've just published our guide to writing custom Lint rules, which should walk you through the steps required to write this Lint check.

Fragment have some existing lint checks in their fragment-lint project, so some of the steps are already taken care of for you (and the existing Lint checks are a good place to look for code examples and testing strategies).

Thanks for offering to help!

ku...@gmail.com <ku...@gmail.com> #5Apr 7, 2021 08:29PM

https://github.com/androidx/androidx/pull/156 PR is ready for this ticket

jb...@google.com <jb...@google.com> #6Apr 22, 2021 05:36PM

Marked as fixed.

Thank you for the pull request! This has been added internally and will be a part of the next Fragment alpha release.

a....@gmail.com <a....@gmail.com> #7Aug 24, 2023 08:47PM

I know the ticket is closed but ..
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)

Issue 170781346