Add lint warning for calling LayoutInflater.from() in onCreateDialog() [170781346]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Oct 14, 2020 07:13AM

When using a DialogFragment, if you want to get a LayoutInflater, you should always call the getLayoutInflater() method from Fragment.

Using LayoutInflater.from(Context) can return a LayoutInflater that does not have the correct theme.

It would be nice if there was a lint rule, that caught all calls to LayoutInflater.from(Context) and suggested to use getLayoutInflater() instead.

Comments

su...@gmail.com <su...@gmail.com> #2Oct 15, 2020 05:44AM

As a workaround using reflection

try {
    Class
        .forName("androidx.compose.material3.TabRowKt")
        .getDeclaredField("ScrollableTabRowMinimumTabWidth").apply {
            isAccessible = true
        }.set(this, 0f)
} catch (e: Exception) {
    e.printStackTrace()
}

su...@gmail.com <su...@gmail.com> #3Oct 16, 2020 05:49AM

this is still an issue on the latest compose stable version 1.5.4

il...@google.com <il...@google.com> #4Oct 16, 2020 02:50PM

Assigned to jb...@google.com.

can I help resolve this issue?

ku...@gmail.com <ku...@gmail.com> #5Apr 7, 2021 08:29PM

Any progress on this?

jb...@google.com <jb...@google.com> #6Apr 22, 2021 05:36PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3501214

[Tabs] Expose minimum scrollable tab width and remove experimental tags for Primary/Secondary variants

Expand for full commit details

[Tabs] Expose minimum scrollable tab width and remove experimental tags for Primary/Secondary variants 
 
Bug: 226665301 
RelNote: "Scrollable tab row's minimum tab width is now a parameter. Primary and Secondary tab row variants are no longer experimental." 
Test: Update unit test tolerance. Manual testing. 
Change-Id: If6f15c267353bf23a8faaa486bd52ed2a61dd29b

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/bcv/native/current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TabTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TabRow.kt

Hash: c1ca7e200b4e3c0ae14d4c59ac954ed1a0fd03f5
Date: Wed Feb 19 11:48:55 2025

a....@gmail.com <a....@gmail.com> #7Aug 24, 2023 08:47PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha10
androidx.compose.material3:material3-android:1.4.0-alpha10
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha10
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha10

Issue 170781346