Add lint warning for calling LayoutInflater.from() in onCreateDialog() [170781346]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Oct 14, 2020 07:13AM

When using a DialogFragment, if you want to get a LayoutInflater, you should always call the getLayoutInflater() method from Fragment.

Using LayoutInflater.from(Context) can return a LayoutInflater that does not have the correct theme.

It would be nice if there was a lint rule, that caught all calls to LayoutInflater.from(Context) and suggested to use getLayoutInflater() instead.

Comments

su...@gmail.com <su...@gmail.com> #2Oct 15, 2020 05:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit b17204359581a71c427d7519a6cfc1825141ed72
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Mar 17 21:47:24 2023

Prevent crash when adding unmanaged fragment in nav

Currently, if you attempt to add a fragment to the fragment manager
associated with the FragmentNavigator, navigation crashes as it cannot
find an entry associated with fragment.

While it is strongly recommended to only use navigation APIs to
manipulate the fragment manager, if the back stack is not affected, then
we should not crash.

RelNote: "Adding fragments to the `FragmentNavigator`'s
`FragmentManager` without using navigation will no longer crash."
Test: Added FragmentNavigatorTest
Bug: 274167493

Change-Id: I47d4c75ca46ee7f8282b2a7b97d28d71edd9a07b

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2496343

su...@gmail.com <su...@gmail.com> #3Oct 16, 2020 05:49AM

This has been fixed internally and will be in the Navigation 2.6.0-alpha08 release.

il...@google.com <il...@google.com> #4Oct 16, 2020 02:50PM

Assigned to jb...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha08

ku...@gmail.com <ku...@gmail.com> #5Apr 7, 2021 08:29PM

https://github.com/androidx/androidx/pull/156 PR is ready for this ticket

jb...@google.com <jb...@google.com> #6Apr 22, 2021 05:36PM

Marked as fixed.

Thank you for the pull request! This has been added internally and will be a part of the next Fragment alpha release.

a....@gmail.com <a....@gmail.com> #7Aug 24, 2023 08:47PM

I know the ticket is closed but ..
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)

Issue 170781346