Fixed
Status Update
No update yet.
Comments
su...@gmail.com
The project uses plugin androidx.navigation.safeargs (version 1.0.0-alpha04) and that seems to change the version of the models to 3.2.0-beta03, causing the project to require an upgrade. If the plugin is removed from the project then the issue is gone. Can you confirm if the issue is gone after removing the plugin? I have attached a patch with the changes if needed.
su...@gmail.com
So maybe this bug needs to be assigned to `androidx.navigation.safeargs` plugin team ?
il...@google.com
We need to review this plugin and see what it does in general.
The fact that a non final plugin depend on a non final version of our plugin and breaks things is sad but not something we can solve easily on our end. (we need to have other plugin depend on a more stable API artifact rather than specific versions of our plugin.
The fact that a non final plugin depend on a non final version of our plugin and breaks things is sad but not something we can solve easily on our end. (we need to have other plugin depend on a more stable API artifact rather than specific versions of our plugin.
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d276ac5482afaf12a78ea357fffe40b2a7964301
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Oct 22 14:18:06 2018
Set fixed Android Gradle Plugin dependency version for SafeArgs.
Fixing the version makes it so that if the plugin is updated to a beta
or alpha version for frameworks/support we don't ship SafeArgs with
a non-stable dependency that can cause olders Android Studio versions
to reject syncing.
Bug: 113167627
Test: SafeArgs Tests
Change-Id: Id2de86e4ac724d6d812ea6bd383059737695e948
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/safe-args-gradle-plugin/build.gradle
https://android-review.googlesource.com/798471
https://goto.google.com/android-sha1/d276ac5482afaf12a78ea357fffe40b2a7964301
Branch: androidx-master-dev
commit d276ac5482afaf12a78ea357fffe40b2a7964301
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Oct 22 14:18:06 2018
Set fixed Android Gradle Plugin dependency version for SafeArgs.
Fixing the version makes it so that if the plugin is updated to a beta
or alpha version for frameworks/support we don't ship SafeArgs with
a non-stable dependency that can cause olders Android Studio versions
to reject syncing.
Bug: 113167627
Test: SafeArgs Tests
Change-Id: Id2de86e4ac724d6d812ea6bd383059737695e948
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/safe-args-gradle-plugin/build.gradle
a....@gmail.com
I know the ticket is closed but ..
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)
Description
When using a
DialogFragment, if you want to get aLayoutInflater, you should always call thegetLayoutInflater()Fragment.Using
LayoutInflater.from(Context)LayoutInflaterthat does not have the correct theme.It would be nice if there was a lint rule, that caught all calls to
LayoutInflater.from(Context)and suggested to usegetLayoutInflater()instead.