Add lint warning for calling LayoutInflater.from() in onCreateDialog() [170781346]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Oct 14, 2020 07:13AM

When using a DialogFragment, if you want to get a LayoutInflater, you should always call the getLayoutInflater() method from Fragment.

Using LayoutInflater.from(Context) can return a LayoutInflater that does not have the correct theme.

It would be nice if there was a lint rule, that caught all calls to LayoutInflater.from(Context) and suggested to use getLayoutInflater() instead.

Comments

su...@gmail.com <su...@gmail.com> #2Oct 15, 2020 05:44AM

Is there any updates? This is a big problem!

su...@gmail.com <su...@gmail.com> #3Oct 16, 2020 05:49AM

Hi there - could you provide more context on the issue & a sample project to reproduce? Database locked exceptions are quite difficult to pinpoint without a repro project. Thanks!

il...@google.com <il...@google.com> #4Oct 16, 2020 02:50PM

Assigned to jb...@google.com.

Hi. It is reproduceable on some users by using this code:

suspend fun <R> MyDatabase.workaroundWithTransaction(block: suspend TransactionScope<R>.() -> R) {
    useWriterConnection {
        it.immediateTransaction(block)
    }

    // TODO: Temporally fix https://issuetracker.google.com/issues/340606803#comment2
    // Manually triggers invalidation
    invalidationTracker.refreshAsync()
}

ku...@gmail.com <ku...@gmail.com> #5Apr 7, 2021 08:29PM

Maybe it is about this? https://android-review.googlesource.com/c/platform/frameworks/support/+/3114928

I am not sure.

jb...@google.com <jb...@google.com> #6Apr 22, 2021 05:36PM

Marked as fixed.

Hi. Please merge the pull request. This is big problem!

a....@gmail.com <a....@gmail.com> #7Aug 24, 2023 08:47PM

Hi. Is there any updates on this problem?

Issue 170781346