Unable to initialize NavBackStackEntry - IllegalStateException: Method addObserver must be called on the main thread [171125856]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 19, 2020 08:57AM

Component used: Navigation

Version used: 2.2.0, 2.3.0, 2.3.1

Devices/Android versions reproduced on: 10.0, 9.0 - probably not related

Description:

I've updated two dependencies in my project:

androidx.fragment:fragment 1.3.0-alpha06 -> 1.3.0-beta01
androidx.activity.activity 1.1.0 -> 1.2.0-beta01

and now I see that NavController::navigate needs to be called from the main thread. Otherwise NavBackStackEntry throws IllegalStateException when trying to register lifecycle observer.

Stacktrace:

Caused by: java.lang.IllegalStateException: Method addObserver must be called on the main thread
    at androidx.lifecycle.LifecycleRegistry.enforceMainThreadIfNeeded(LifecycleRegistry.java:317)
    at androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.java:172)
    at androidx.savedstate.SavedStateRegistryController.performRestore(SavedStateRegistryController.java:61)
    at androidx.navigation.NavBackStackEntry.<init>(NavBackStackEntry.java:84)
    at androidx.navigation.NavBackStackEntry.<init>(NavBackStackEntry.java:69)
    at androidx.navigation.NavController.navigate(NavController.java:970)
    at androidx.navigation.NavController.navigate(NavController.java:867)

There were no changes in documentation so I assume that this behavior is unintended.

Comments

il...@google.com <il...@google.com> #2Oct 19, 2020 08:10PM

it was found that EXIF_TAGS includes IFD_TIFF_TAGS twice

This duplication has always been present in the AndroidX version of ExifInterface. It looks like it was inherited from the platform version, where it was added in 2016 in https://cs.android.com/android/_/android/platform/frameworks/base/+/1674546669b1f82955aeb86c17361c7a97d0ebb3.

[Deleted User] <[Deleted User]> #3Oct 20, 2020 07:19AM

The duplication of IFD_TIFF_TAGS is also discussed in internal b/249097443#comment5.

ap...@google.com <ap...@google.com> #4Apr 6, 2021 10:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit 77ac31b4e0d83f5cee16dc6c50da6f26a1f5a4d3
Author: Ian Baker <ibaker@google.com>
Date: Thu Mar 28 16:49:00 2024

Ensure XMP data isn't duplicated into Exif segment when saving

Test: ExifInterfaceTest
Bug: 309843390
Change-Id: I56b6defea9b5e800d426cb050b19bea03f614b15

M exifinterface/exifinterface/src/androidTest/java/androidx/exifinterface/media/ExifInterfaceTest.java
M exifinterface/exifinterface/src/main/java/androidx/exifinterface/media/ExifInterface.java

https://android-review.googlesource.com/3017513

il...@google.com <il...@google.com> #5Apr 6, 2021 10:17PM

Marked as fixed, reassigned to il...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.exifinterface:exifinterface:1.4.0-alpha01

ap...@google.com <ap...@google.com> #6Apr 12, 2021 11:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 00c608a86c44b066198bd8c1dc7e2aef6088d4e1
Author: Ian Lake <ilake@google.com>
Date: Mon Apr 12 14:04:54 2021

Mark popBackStack and navigateUp as @MainThread

In addition to the navigate() and setGraph()
methods updated in

https://android-review.googlesource.com/1665821
the methods for popping the back stack
should also be marked as @MainThread.

Relnote: "Navigation now depends on
[Lifecycle `2.3.1`](/jetpack/androidx/releases/lifecycle#2.3.1)
and now marks all of the methods that update the
`NavBackStackEntry` `Lifecycle`, including `setGraph()`,
`navigate()`, `popBackStack()`, and `navigateUp()`,
as `@MainThread`, aligning Navigation with the main thread
enforcement introduced in Lifecycle `2.3.0`."
Test: existing and updated tests pass
BUG: 171125856

Change-Id: Ib8bedbb3fe384b28c7441cbd57a0751eba307a2b

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1673448

Issue 171125856