Unable to initialize NavBackStackEntry - IllegalStateException: Method addObserver must be called on the main thread [171125856]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 19, 2020 08:57AM

Component used: Navigation

Version used: 2.2.0, 2.3.0, 2.3.1

Devices/Android versions reproduced on: 10.0, 9.0 - probably not related

Description:

I've updated two dependencies in my project:

androidx.fragment:fragment 1.3.0-alpha06 -> 1.3.0-beta01
androidx.activity.activity 1.1.0 -> 1.2.0-beta01

and now I see that NavController::navigate needs to be called from the main thread. Otherwise NavBackStackEntry throws IllegalStateException when trying to register lifecycle observer.

Stacktrace:

Caused by: java.lang.IllegalStateException: Method addObserver must be called on the main thread
    at androidx.lifecycle.LifecycleRegistry.enforceMainThreadIfNeeded(LifecycleRegistry.java:317)
    at androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.java:172)
    at androidx.savedstate.SavedStateRegistryController.performRestore(SavedStateRegistryController.java:61)
    at androidx.navigation.NavBackStackEntry.<init>(NavBackStackEntry.java:84)
    at androidx.navigation.NavBackStackEntry.<init>(NavBackStackEntry.java:69)
    at androidx.navigation.NavController.navigate(NavController.java:970)
    at androidx.navigation.NavController.navigate(NavController.java:867)

There were no changes in documentation so I assume that this behavior is unintended.

Comments

il...@google.com <il...@google.com> #2Oct 19, 2020 08:10PM

since these are in public API (:/) we need to do this in 1.2

[Deleted User] <[Deleted User]> #3Oct 20, 2020 07:19AM

since it is already marked as deprecated, we can probably do it by now.

ap...@google.com <ap...@google.com> #4Apr 6, 2021 10:13PM

Opening diff shortly

il...@google.com <il...@google.com> #5Apr 6, 2021 10:17PM

Marked as fixed, reassigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

ap...@google.com <ap...@google.com> #6Apr 12, 2021 11:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 00c608a86c44b066198bd8c1dc7e2aef6088d4e1
Author: Ian Lake <ilake@google.com>
Date: Mon Apr 12 14:04:54 2021

Mark popBackStack and navigateUp as @MainThread

In addition to the navigate() and setGraph()
methods updated in

https://android-review.googlesource.com/1665821
the methods for popping the back stack
should also be marked as @MainThread.

Relnote: "Navigation now depends on
[Lifecycle `2.3.1`](/jetpack/androidx/releases/lifecycle#2.3.1)
and now marks all of the methods that update the
`NavBackStackEntry` `Lifecycle`, including `setGraph()`,
`navigate()`, `popBackStack()`, and `navigateUp()`,
as `@MainThread`, aligning Navigation with the main thread
enforcement introduced in Lifecycle `2.3.0`."
Test: existing and updated tests pass
BUG: 171125856

Change-Id: Ib8bedbb3fe384b28c7441cbd57a0751eba307a2b

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1673448

Issue 171125856