Fixed
Status Update
No update yet.
Comments
jd...@xooloo.com
While trying to plug a custom build system using the steps listed in the following page (
-
Not directly matching one of the params listed ("-p:Platform=Foo", "-p:Configuration=Bar") exactly results in an error.
- For example:
- [
bug 213607318 https://issuetracker.google.com/213607318
- [
- Because of this using your own generator is painful since I need now support directly options form ninja or cmake (however using CMake's mentioned options also seems to not be accepted)
- For example:
-
The generated command file is NOT a valid batch script, calling it directly fails with the following error:
"{ninja.configure}" ^ "{ninja.path}" ^ configure ^ "-p:Configuration=release" ^ "-p:Platform=arm64-v8a" from <path>\build\android_gradle\simple =release"" was unexpected at this time.
The configuration is the following:
experimentalProperties["ninja.abiFilters"] = listOf("arm64-v8a")
experimentalProperties["ninja.path"] = "arbitrary_file"
experimentalProperties["ninja.configure"] = "command"
experimentalProperties["ninja.arguments"] = listOf(
"\${ndk.moduleMakeFile}",
"configure",
"-p:Configuration=\${ndk.variantName}",
"-p:Platform=\${ndk.abi}"
Any help resolving the issues either by workarounds or ideas would help a lot! Thanks in advance!
Description
I'm using a custom PagingSource backed by a SparseArray and a RemoteMediator to feed the SparseArray when more items are needed and invalidates the PagingSource.
With the alpha08 version of Paging, I was having the same bug as the one reported by 172000108, but the insertSeparators function was working fine (I'm just displaying a header before each item).
With the snapshot version, it is not crashing anymore, but the insertSeparators is not inserting a header before the first item in the list.
It seems to me that it is related to the new terminatesStart function in Separators.kt on CombinedLoadStates. When I use a PagingSource generated by Room, it returns true, and the headers are all displayed.
But with a remote mediator, it returns false, that's why the first header might not displayed.
My remote mediator is first called with loadType REFRESH then with PREPEND (i always return endOfPaginationReached = true for this case, as I only append items). So the mediator.prepend of CombinedLoadStates is eventually terminal (first NotLoading(endOfPaginationReached = false) then NotLoading(endOfPaginationReached = true).
But my PagingSource is never called with a params Prepend (I would return an empty list and both null for prev and next keys if it was called). So source.prepend is never terminal (always NotLoading(endOfPaginationReached = false).