Status Update
No update yet.
Comments
ap...@google.com
The code referred to can be found in
override fun onResume() {
super.onResume()
if (navigated) {
findNavController().popBackStack()
return
}
var monitor = installViewModel.installMonitor
if (monitor == null) {
Log.i(TAG, "onResume: monitor is null, navigating")
navigate()
monitor = installViewModel.installMonitor
}
if (monitor != null) {
Log.i(TAG, "onResume: monitor is now not null, observing")
monitor.status.observe(this, StateObserver(monitor))
}
}
In case no monitor is attached during onResume, we assign the installMonitor from installViewModel.
In either case a new StateObserver is attached, which then observes status changes.
Once SplitSessionInstallState.INSTALLED is observed, navigate() is invoked from within StateObserver.
Since navigate is called in the StateObserver we might see multiple invocations by accident.
To alleviate this, we could create a Event
Alternatively, moving the calls from onResume earlier in the lifecycle, e.g. onCreateView could avoid unnecessary view creation in case navigation already has taken place, and could avoid multiple calls to the observed status.
ap...@google.com
Branch: androidx-master-dev
commit 29c5aee2bf2685e3bc2a0e38ca0290408aa65b11
Author: Ben Weiss <benweiss@google.com>
Date: Tue Nov 03 14:41:39 2020
Move install monitor observation to onViewCreated
Bug: 169636207
Test: Existing tests pass
Change-Id: Ia0c1d903066a5206de5b862eb2a0d9e0899c690b
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/AbstractProgressFragment.kt
ap...@google.com
This has been fixed and will be available in an upcoming Navigation 2.3.2 release.
ap...@google.com
#4 I think this fix break the behavior of DefaultProgressFragment, it doesn't call super.onViewCreated() so that the installation won't execute.
ap...@google.com
onViewCreated
Can you provide more information as to how your installation won't execute?
ap...@google.com
Move install monitor observation to onViewCreated
DefaultProgressFragment won't execute super(AbstractProgressFragment)'s onViewCreated(). So after this change, DefaultProgressFragment can't monitor the installation progress.
ap...@google.com
TL;DR
Call super.onViewCreated(view, savedInstanceState) in DefaultProgressFragment will solve this issue.
ap...@google.com
Branch: androidx-master-dev
commit 524a4f074b688975041f6ddd9db9eb31a88410e8
Author: Ben Weiss <benweiss@google.com>
Date: Tue Dec 15 12:26:06 2020
Add missing onViewCreated call
DefaultProgressFragment did not call super.onViewCreated which
could lead to installation progress not completing.
Bug: 169636207
Test: N/A
RelNote: Fix stuck installation progress
Change-Id: Ib27a77bc4572fc69cea38d738255c987449d6137
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/DefaultProgressFragment.kt
ap...@google.com
Why this fix doesn't included in 2.3.3?
il...@google.com
Re #10, yes, you're right this didn't make it into Navigation 2.3.3. Sorry about that. We'll look at doing a Navigation 2.3.4 with this fix.
Description
Navigation Compose has APIs that would be a better fit as part of the base Navigation library. Instead of allowing Navigation Compose to go to 1.0.0 stable with the libraries and attempting to deprecate them later when they are added to base Navigation, we should instead add those APIs to the next version of Navigation and move Navigation Compose in sync with that.
This means that Navigation Compose will be part of Navigation 2.4.0 instead of an 1.0.0.