Merge navigation compose into the navigation library [172823546]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Nov 9, 2020 04:45PM

Navigation Compose has APIs that would be a better fit as part of the base Navigation library. Instead of allowing Navigation Compose to go to 1.0.0 stable with the libraries and attempting to deprecate them later when they are added to base Navigation, we should instead add those APIs to the next version of Navigation and move Navigation Compose in sync with that.

This means that Navigation Compose will be part of Navigation 2.4.0 instead of an 1.0.0.

Comments

ap...@google.com <ap...@google.com> #2Nov 9, 2020 11:19PM

ap...@google.com <ap...@google.com> #3Apr 2, 2021 06:25PM

lblb636@ Thanks for reporting this bug. I just want to confirm that the issue is the call device button being not responsive according to the uploaded video. It seems like this issue only happened on Windows.

ap...@google.com <ap...@google.com> #4May 3, 2021 06:55PM

@3 Why does it occur?
And why only from specific API of Android?
On API 28 for example, it doesn't occur...

Please fix this issue for all API versions of the emulator.

ap...@google.com <ap...@google.com> #5May 4, 2021 12:15AM

Another similar issue that's related https://b.corp.google.com/issues/226426377

ap...@google.com <ap...@google.com> #6May 5, 2021 05:28PM

RE#4 I need to try this on Windows laptop first and I couldn't repro on MacOS or Linux. But I think this is most likely related to the modem simulator we introduced for API 31. Will need to further investigate.

ap...@google.com <ap...@google.com> #7May 5, 2021 09:46PM

@6 There are plenty of issues on emulator API 31 (and on Android 13 emulator). Many glitches. Spend 5 minutes on it and you will notice.
Why isn't the emulator tested more on Windows OS?
Windows OS is more popular than Linux and MacOS combined (on desktop) ...

ap...@google.com <ap...@google.com> #8May 6, 2021 07:44PM

@6 Also please check on all versions of the emulator, to see when this issue started, and fix from there.

ap...@google.com <ap...@google.com> #9May 7, 2021 12:02AM

I reproduced this bug on Windows with emulator version 31.2.10-8420304

ap...@google.com <ap...@google.com> #10May 7, 2021 12:02AM

@9 Please test on more API versions.

il...@google.com <il...@google.com> #11May 10, 2021 11:14PM

Marked as fixed.

Found the root cause when the "call device" button was unresponsive. It became unresponsive because the inbound call failed to initialize. Basically, the modem simulator's shared FD failed. When receive_inbound_call is invoked, it is supposed to make connection to the "host server" via a shared fd but it is flaky on Windows unfortunately.

modem-simulator: receive_inbound_call:101 inbound call from 6505551212
modem-simulator: process_msgs:296 waiting for new messages ...
modem-simulator: main_host_thread:501 got connection at host server at 65094
modem-simulator: start_calling_thread:254 making a connection to main host server 65094
modem-simulator: main_host_thread:507 Detected close from the other side
modem-simulator: start_calling_thread:262 nothing read quit
modem-simulator: main_host_thread:494 looping at main host server at 65094
modem-simulator: start_calling_thread:284 done with this thread