Merge navigation compose into the navigation library [172823546]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Nov 9, 2020 04:45PM

Navigation Compose has APIs that would be a better fit as part of the base Navigation library. Instead of allowing Navigation Compose to go to 1.0.0 stable with the libraries and attempting to deprecate them later when they are added to base Navigation, we should instead add those APIs to the next version of Navigation and move Navigation Compose in sync with that.

This means that Navigation Compose will be part of Navigation 2.4.0 instead of an 1.0.0.

Comments

ap...@google.com <ap...@google.com> #2Nov 9, 2020 11:19PM

Please include a sample project that reproduces your issue.

ap...@google.com <ap...@google.com> #3Apr 2, 2021 06:25PM

Sample project attached. Just add to plain project this dependencies allow to reproduce.

def emoji2_version = "1.1.0-beta01"
implementation "androidx.emoji2:emoji2:$emoji2_version"

def lifecycle_version = "2.5.0-alpha01"
implementation "androidx.lifecycle:lifecycle-process:$lifecycle_version"

ap...@google.com <ap...@google.com> #4May 3, 2021 06:55PM

The reason may be related to this change, which check itself before it is initialized. Use 2.4.0 of lifecycle-process as workaround.

ap...@google.com <ap...@google.com> #5May 4, 2021 12:15AM

Yes, this is due to this change, as well as the fact that EmojiCompatInitializer has a ProcessLifecycleInitializer as a dependency and also re-calls it, but in manual mode.

ap...@google.com <ap...@google.com> #6May 5, 2021 05:28PM

ProcessLifecycleInitializer is expected to already be initialized (via the manifest provider for App Startup) by the time that code runs - App Startup shouldn't be calling create if that component has already been initialized, hence you shouldn't get any exception. We'll take a look on where things are breaking down though.

ap...@google.com <ap...@google.com> #7May 5, 2021 09:46PM

Thanks for the answer.

As I understand EmojiCompatInitializer has ProcessLifecycleInitializer as a dependency. That is mean, the ProcessLifecycleInitializer must be executed before the EmojiCompatInitializer, which in its create method calls the delayUntilFirstResume method, which in turn calls the ProcessLifecycleInitializer via appInitializer.initializeComponent(ProcessLifecycleInitializer.class)

Maybe it would be more correct to create a bug in emoji-2, but let it be here.

ap...@google.com <ap...@google.com> #8May 6, 2021 07:44PM

This issue isn't related to emoji2, it could be reproduced easily with the lifecycle-process (2.4.0 -> 2.5.0-alpha01) only.

ap...@google.com <ap...@google.com> #9May 7, 2021 12:02AM

Project: platform/frameworks/support
Branch: androidx-main

commit 97993ad954cb98211ef52b6e26c7877dbdeeec1c
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 01 17:06:11 2022

Bump lifecycle process start-up dependency to 1.1.1

Bumping the startup dependency to include aosp/1855769.

RelNote: "Updated `lifecycle-process` to depend on [Startup 1.1.1](/jetpack/androidx/releases/startup#1.1.1) to ensure that fixes that prevent `ProcessLifecycleInitializer` from throwing a `StartupException` are available by default."
Bug: 216490724
Test: tested in sample app

Change-Id: Ib01dfbba1d63aa03e43e09ee8886cc76e1050e1b

M lifecycle/lifecycle-process/build.gradle

https://android-review.googlesource.com/1964554

ap...@google.com <ap...@google.com> #10May 7, 2021 12:02AM

This has been fixed internally and will be released in the Lifecycle 2.5.0-alpha02 release.

il...@google.com <il...@google.com> #11May 10, 2021 11:14PM

Marked as fixed.

When will start-up 1.1.1 release?