Fixed
Status Update
No update yet.
Comments
pe...@gmail.com
Warnings is still present today in 4.3 canary 15
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 39ac753d893ff88f73bc5099109ea22566619da4
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 10:51:12 2021
Update safe-args to AGP 4.2.0
AGP 4.2.0 has gone stable and it includes Variant.getApplicationId
and we should rely on that instead of the now deprecated
BaseVariant.getApplicationIdTestResource.
RelNote: "Safe-Args now depends on AGP 4.2.0. This removes the using
`applicationIdTextResource` warning."
Test: existing tests pass
Bug: 172824579
Change-Id: I6d67ba2067b42b57463efe5872f345058379ab40
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1701565
Branch: androidx-main
commit 39ac753d893ff88f73bc5099109ea22566619da4
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 10:51:12 2021
Update safe-args to AGP 4.2.0
AGP 4.2.0 has gone stable and it includes Variant.getApplicationId
and we should rely on that instead of the now deprecated
BaseVariant.getApplicationIdTestResource.
RelNote: "Safe-Args now depends on AGP 4.2.0. This removes the using
`applicationIdTextResource` warning."
Test: existing tests pass
Bug: 172824579
Change-Id: I6d67ba2067b42b57463efe5872f345058379ab40
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.4.0-alpha02 release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f76869ae3ec564e4c334dec53253a4a98634fb59
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed May 26 17:49:41 2021
Modify safe-args plugin implementation
We are currently never actually calling the new VariantAPIs cause of an
incorrect if check. This fixes that and some other smaller
implementation details of the safe-args plugin.
Test: existing tests pass
Bug: 172824579
Change-Id: I0d80324e5f0e074a7ea4f864f1e50e6b8e68ff0c
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1720260
Branch: androidx-main
commit f76869ae3ec564e4c334dec53253a4a98634fb59
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed May 26 17:49:41 2021
Modify safe-args plugin implementation
We are currently never actually calling the new VariantAPIs cause of an
incorrect if check. This fixes that and some other smaller
implementation details of the safe-args plugin.
Test: existing tests pass
Bug: 172824579
Change-Id: I0d80324e5f0e074a7ea4f864f1e50e6b8e68ff0c
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
Description
Android Gradle Plugin deprecated the
getApplicationIdTextResource()API on the classBaseVariantin version4.1.0(onVariantProperties) did not work properly for feature libraries, so to avoid the deprecation warning,4.2.0is stable we should update to that version and remove the reflection immediately.