Fixed
Status Update
No update yet.
Comments
du...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4ba20c0183e46f83483af4a8019ad6fb84d1c0c2
Author: Ian Lake <ilake@google.com>
Date: Wed Jun 03 10:46:12 2020
Request Insets only once the Fragment's View is attached
Instead of unconditionally calling
requestApplyInsets() directly before onViewCreated(),
we should always wait for the View to be attached
to its window so that requestApplyInsets() actually
works correctly for every Fragment.
This is a half step towards the final solution in
the View is attached.
Test: tested in sample app
BUG: 158095749
Change-Id: Ie187051553437d77fd788ece52d8ec083e29f2e4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1323649
Branch: androidx-master-dev
commit 4ba20c0183e46f83483af4a8019ad6fb84d1c0c2
Author: Ian Lake <ilake@google.com>
Date: Wed Jun 03 10:46:12 2020
Request Insets only once the Fragment's View is attached
Instead of unconditionally calling
requestApplyInsets() directly before onViewCreated(),
we should always wait for the View to be attached
to its window so that requestApplyInsets() actually
works correctly for every Fragment.
This is a half step towards the final solution in
the View is attached.
Test: tested in sample app
BUG: 158095749
Change-Id: Ie187051553437d77fd788ece52d8ec083e29f2e4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
du...@google.com
ta...@gmail.com
This has been fixed internally and will be available in Fragment 1.3.0-alpha07.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3bafac069a856b0f6f226f88bac69b1fe95bebaf
Author: Dustin Lam <dustinlam@google.com>
Date: Mon Nov 23 23:14:12 2020
Allow remote to send NotLoading.Incomplete via LoadStateUpdate
Due to remote loads being completely async with local insert, it's no
longer possible to guarantee that local insert will finish after remote
load. This leads to situations where it's possible for remote load state
to get stuck in "Loading" state forever.
This change enables RemoteMediator to fire off LoadState events to
update to NotLoading.Incomplete, but comes with the caveat that
CombinedLoadState.mediator.refresh is now no longer
sufficient to check for displaying loadstate in UI as it may set
NotLoading before PagingSource.load finishes (and presents to the UI).
In previous versions this was worked around by resetting the Mediator
loadstate on new generations, but this is no longer accurate since those
calls don't necessarily get canceled.
Fixes: 173717820
Test: ./gradlew paging:paging-common:test
Change-Id: I2f1236fcb37777d059de3a53bbcd2a7aa038d479
M paging/common/src/main/kotlin/androidx/paging/PageEvent.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/common/src/test/kotlin/androidx/paging/RemoteMediatorAccessorTest.kt
https://android-review.googlesource.com/1509156
Branch: androidx-master-dev
commit 3bafac069a856b0f6f226f88bac69b1fe95bebaf
Author: Dustin Lam <dustinlam@google.com>
Date: Mon Nov 23 23:14:12 2020
Allow remote to send NotLoading.Incomplete via LoadStateUpdate
Due to remote loads being completely async with local insert, it's no
longer possible to guarantee that local insert will finish after remote
load. This leads to situations where it's possible for remote load state
to get stuck in "Loading" state forever.
This change enables RemoteMediator to fire off LoadState events to
update to NotLoading.Incomplete, but comes with the caveat that
CombinedLoadState.mediator.refresh is now no longer
sufficient to check for displaying loadstate in UI as it may set
NotLoading before PagingSource.load finishes (and presents to the UI).
In previous versions this was worked around by resetting the Mediator
loadstate on new generations, but this is no longer accurate since those
calls don't necessarily get canceled.
Fixes: 173717820
Test: ./gradlew paging:paging-common:test
Change-Id: I2f1236fcb37777d059de3a53bbcd2a7aa038d479
M paging/common/src/main/kotlin/androidx/paging/PageEvent.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/common/src/test/kotlin/androidx/paging/RemoteMediatorAccessorTest.kt
Description
Version used: 3.0.0-alpha08 or 3.0.0-alpha09
Devices/Android versions reproduced on: Samsung Galaxy S8 / Android 9
Starting with version 3.0.0-alpha08 of the Paging library, the MediatorResult.Success(false) value returned from a RemoteMediator.load(LoadType.REFRESH, state) call doesn’t trigger a RemoteMediator.load(LoadType.APPEND, state) call and doesn’t update PagingDataAdapter.loadStateFlow to notify that the refresh state has changed from LoadState.Loading to LoadState.NotLoading.
This bug can be reproduced by means of the following project, if you’ve changed the version of the Paging library it uses so that it’s equal to 3.0.0-alpha08 or 3.0.0-alpha09: