Add Lint Warning or Deprecate usages of <deeplink> inside <activity> tag. [178403185]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

Jan 26, 2021 02:53PM

Component used: Navigation Version used: 2.3.2

It has been recommended that using <deeplink> inside an <activity> tag on navigation graph should not be used as it has unintended side effects (as per this issue - https://issuetracker.google.com/issues/174934674). Would it be possible to deprecate this feature so that new developers are also aware of this issue? Or a lint warning would also help convey that this is not the correct approach going forward.

Comments

il...@google.com <il...@google.com> #2Jan 26, 2021 08:57PM

Assigned to jb...@google.com.

Using navigation version 2.6.0 and 2.7.1 the issue still persists.

After further investigation, the behaviour can be corrected by filtering on backstack entries where current state is at least started. In my opinion the name visibleEntries is misleading if it contains entries that are not actually visible or in transition.

as...@google.com <as...@google.com> Apr 15, 2022 02:36PM

Reassigned to ju...@google.com.

jb...@google.com <jb...@google.com> #3Apr 15, 2022 09:35PM

Note that as per the visibleEntries documentation, it is expected that there are entries that are in the CREATED state - those are the entries that are in the process of being removed (i.e., they are no longer in the back stack, but have not yet marked their transition as complete).

It is a bug that those entries aren't removed when their exit animation completes and that's what we'll be looking into.

as...@google.com <as...@google.com> #4Apr 18, 2022 01:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit f61da31809827bfac89af629c88ad9b8423e88b6
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 06 14:14:11 2023

Fix entry not marked complete after view is destroyed

As part of a fix for

b/279644470

in aosp/2566210, when the fragment view is destroyed, we would mark the transitioning (outgoing) entry as complete only if the entry has also been removed from backstack. However, in the simple navigate() case where the outgoing entry is not popped and remains in the backstack, this entry is not marked complete and ends up in the visibleEntries even though the view has been destroyed.

Now the backstack check in ON_DESTROY is no longer necessary to fix the original

b/279644470

bug -- the view being destroyed should be the right signal for completing entries regardless of whether transitioning effects are used. So this check is removed.

Test: ./gradlew navigation:navigation-fragment:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 288520638
Change-Id: I5caa9af1b5bd7084e76d7daf9515f7430bf2489d

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2743918

ap...@google.com <ap...@google.com> #5Apr 22, 2022 02:17PM

Fixed internally and will be available in navigation 2.7.3

il...@google.com <il...@google.com> Apr 25, 2022 10:35PM

Marked as fixed.

Issue 178403185