Add Lint Warning or Deprecate usages of <deeplink> inside <activity> tag. [178403185]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

Jan 26, 2021 02:53PM

Component used: Navigation Version used: 2.3.2

It has been recommended that using <deeplink> inside an <activity> tag on navigation graph should not be used as it has unintended side effects (as per this issue - https://issuetracker.google.com/issues/174934674). Would it be possible to deprecate this feature so that new developers are also aware of this issue? Or a lint warning would also help convey that this is not the correct approach going forward.

Comments

il...@google.com <il...@google.com> #2Jan 26, 2021 08:57PM

Assigned to jb...@google.com.

Building note: run ./gradlew ... -x processReleaseMetadata

as...@google.com <as...@google.com> Apr 15, 2022 02:36PM

Reassigned to ju...@google.com.

jb...@google.com <jb...@google.com> #3Apr 15, 2022 09:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018

Fix ViewModel proguard rules

It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection

Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c

M lifecycle/viewmodel/proguard-rules.pro

https://android-review.googlesource.com/727573

https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38

as...@google.com <as...@google.com> #4Apr 18, 2022 01:22PM

Thanks!

ap...@google.com <ap...@google.com> #5Apr 22, 2022 02:17PM

I had the similar problem. Hoping the problem will be fixed in the next release. Thank team!

il...@google.com <il...@google.com> Apr 25, 2022 10:35PM

Marked as fixed.

Issue 178403185