IssueTracker

Wow, it seems like a very important bug to fix.

Doing some investigations...

It works fine with CoreTextField as well as BaseTextField.

Seems to be a duplicate of b/163834907

It works fine with Material TextFields (both filled and outline) if you use TextFieldValue based overloads.

It doesn't work when you use String based overloads however (both Outline and Filled). I believe this is related to the one-frame lag as we host TextFieldValue internally and proxy only string.

Chatted with Anastasia.

We have this code

// "value: String" comes as a param in TextField
TextFieldImpl(
        type = TextFieldType.Outlined,
        value = textFieldValue,
        onValueChange = {
            selection = it.selection
            composition = it.composition
            if (value != it.text) {
                onValueChange(it.text)
            }
        },

and this value is always "" for me, as it's captured my lambda when lambda was created and this lambda is saved and reused by CoreTextField.

Anyway, two things we can do:

1. Remove this if and invoke onValueChange everytime, even on the selection change (which we don't care about). This will allow us to workaround quickly and not to let it slip through.
2. Find and implement the proper fix in CoreTextField

Let me know what you think

Updated the details here b/163834907.

Just a note that this issue affects String overrides of both material text fields as well as any custom String override text fields that developer might create on top of CoreTextField/BaseTextField.

Which release is this fix going to be a part of? Also, what's the best way to know which version a change will be a part of in general?

This fix will be available in the upcoming release.

As for the second question, I'm not sure I've got a good answer for that one. I'd say normally if it's marked as fixed, it'll be available within two next releases.

This has been added internally and will be released as part of the compose.material library, not navigation.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.material:material:1.7.0-alpha04
• androidx.compose.material:material-android:1.7.0-alpha04
• androidx.compose.material:material-desktop:1.7.0-alpha04

I guess the release that addresses this is actually: androidx.compose.material:material-navigation:1.7.0-alpha04

As #13 said, we are missing this for Material3 bottom sheets. I see that there's another issue tracking that here: https://issuetracker.google.com/issues/328949006

Some guidance about usage would be very welcome. I get java.lang.IllegalStateException: Could not find Navigator with name "bottomSheet". You must call NavController.addNavigator() for each navigation type. crash and can't find any proper example of this new extension usage:

                Scaffold(
                    bottomBar = {...}
                      
                ) { innerPadding ->

                    NavHost(
                        navController,
                        startDestination = "explore_graph",
                        Modifier.fillMaxSize()
                    ) {
                        // nested graphs

                        bottomSheet("profile_bottom_sheet") { // CRASHES
                            Text("Bottom Sheet", Modifier.padding(16.dp))
                        }
                    }
                }
            }
        }
    }
}

I use androidx.compose.material:material-navigation:1.7.0-beta01, but my project is material3, could it be the reason?

Re comment#15 - Material Navigation works similarly to Accompanist, whose docs explain how to use it, including these two lines:

val bottomSheetNavigator = rememberBottomSheetNavigator()
val navController = rememberNavController(bottomSheetNavigator)

If you don't use those lines, you'd get that error message.