Integration with BottomSheetScaffold [180247978]

Fixed

Feature Request

Status Update

No update yet.

Description

ja...@vitruvian.me

created issue #1

Feb 16, 2021 04:13AM

Component used: Navigation
Version used: 1.0.0-alpha06

It would be useful to integrate with BottomSheetScaffold so we could treat bottom sheets as navigation destinations. For example, I could call `navController.navigate(someBottomSheetRoute)` to launch a bottom sheet.

Comments

wh...@gmail.com <wh...@gmail.com> #2Jul 20, 2021 11:19AM

Hi,

This looks really bad but w/o a repro app, we really cannot do anything about it. Is it possible for you to provide a sample app that reproduces your problem ?

[Deleted User] <[Deleted User]> #3Jul 20, 2021 04:28PM

Attached is a simple testing app. It inserts 10000 items into the db when activity starts and then displays them using paging. The db is also updated every 1 second. On the screen, if you drag the fast scroll bar up and down quickly a few times, it will eventually crash with this IndexOutOfBoundsException error.

il...@google.com <il...@google.com> #4Jul 20, 2021 05:52PM

Thanks for the great repro case, tracked it down, investigating a fix.

Problematic behavior:
1) AsyncPagedListDiffer receives new list, takes snapshot for diffing (ui thread)
2) At roughly the same time:
2a) Diff snapshot of old snapshot vs new snapshot (bg thread)
2b) New data arrives in new list, way earlier in the list, so the list is essentially: new page, lots of empty pages, initial load
3) AsyncPagedListDiffer updates lastLoad position with diffutil position mapping

In 3, we try to map the lastLoad position from old snapshot to new snapshot, but fail to distinguish between new list vs new snapshot. Because of all the empty pages, that's a huge discrepancy. This is why the huge scrollbar + lots of swaps triggers this well - there are lots of swaps to new PagedLists while loads are happening very far away from initial load positions.

Will need to account for pages loaded in between time of snapshot, and time of swap.

jo...@jossiwolf.de <jo...@jossiwolf.de> #5Jul 22, 2021 05:48PM

Fixed with

https://android-review.googlesource.com/c/platform/frameworks/support/+/758685

Unfortunately, I don't have a workaround, will try and get this released shortly.

jo...@jossiwolf.de <jo...@jossiwolf.de> #6Aug 5, 2021 08:23AM

Awesome! Can not wait for the fix to drop.

il...@google.com <il...@google.com> Oct 5, 2021 10:24PM

Assigned to jb...@google.com.

de...@gmail.com <de...@gmail.com> #7Jun 2, 2022 11:54AM

I saw a new WorkManager version was dropped today but no new paging. Any ideas when this fix will be released? Days or weeks? Thanks.

Message last modified on Jun 2, 2022 11:55AM

pa...@gmail.com <pa...@gmail.com> #8Jun 30, 2022 06:28PM

no promises but it is already scheduled so should be days hopefully.

il...@google.com <il...@google.com> #9Jun 30, 2022 11:02PM

Released with Paging 2.0.0

ap...@google.com <ap...@google.com> #10Feb 27, 2024 05:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit d65d5731e4f0dfe560b43eae886a4fabfa949b84
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 21 02:14:42 2024

Add Navigation Material from Accompanists to androidx

Now that the needed compose material API are stable, we can move the
navigation material module from Accompanists to Androidx. This means we
will have a new compose-material-navigation module that provides support
for bottomsheets.

RelNote: "Providing new Compose Material Navigation module that adds
support for Bottomsheets in Compose Material."
Test: Added tests and samples
Bug: 180247978

Change-Id: Ia93eb757a32b04dac8ab3ebd2d73207a68635b80

A compose/material/material-navigation/api/current.txt
A compose/material/material-navigation/api/res-current.txt
A compose/material/material-navigation/api/restricted_current.txt
A compose/material/material-navigation/build.gradle
A compose/material/material-navigation/samples/build.gradle
A compose/material/material-navigation/samples/src/main/java/androidx/compose/material/navigation/samples/ComposeMaterialNavigationSamples.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/BottomSheetNavigatorTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/SheetContentHostTest.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigator.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/SheetContentHost.kt
M compose/material/material/integration-tests/material-demos/build.gradle
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M docs-tip-of-tree/build.gradle
M settings.gradle

https://android-review.googlesource.com/2953937

jb...@google.com <jb...@google.com> #11Feb 27, 2024 05:03PM

Marked as fixed.

This has been added internally and will be released as part of the compose.material library, not navigation.

na...@google.com <na...@google.com> #12Mar 6, 2024 07:49PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha04
androidx.compose.material:material-android:1.7.0-alpha04
androidx.compose.material:material-desktop:1.7.0-alpha04

d....@gmail.com <d....@gmail.com> #13Apr 2, 2024 01:55PM

Is there any fix planned for the material3 library for the above? We are currently using the material3 library in our project and would be helpful for us

gs...@gmail.com <gs...@gmail.com> #14Apr 21, 2024 12:11PM

I guess the release that addresses this is actually: androidx.compose.material:material-navigation:1.7.0-alpha04

As #13 said, we are missing this for Material3 bottom sheets. I see that there's another issue tracking that here: https://issuetracker.google.com/issues/328949006

v....@temper.works <v....@temper.works> #15Aug 6, 2024 11:02AM

Some guidance about usage would be very welcome. I get java.lang.IllegalStateException: Could not find Navigator with name "bottomSheet". You must call NavController.addNavigator() for each navigation type. crash and can't find any proper example of this new extension usage:

                Scaffold(
                    bottomBar = {...}
                      
                ) { innerPadding ->

                    NavHost(
                        navController,
                        startDestination = "explore_graph",
                        Modifier.fillMaxSize()
                    ) {
                        // nested graphs

                        bottomSheet("profile_bottom_sheet") { // CRASHES
                            Text("Bottom Sheet", Modifier.padding(16.dp))
                        }
                    }
                }
            }
        }
    }
}

I use androidx.compose.material:material-navigation:1.7.0-beta01, but my project is material3, could it be the reason?

il...@google.com <il...@google.com> #16Aug 6, 2024 11:34AM

Re comment#15 - Material Navigation works similarly to Accompanist, whose docs explain how to use it, including these two lines:

val bottomSheetNavigator = rememberBottomSheetNavigator()
val navController = rememberNavController(bottomSheetNavigator)

If you don't use those lines, you'd get that error message.