Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit df2d4fd54fbf766df31c1a07c33464ece5872783
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 29 14:48:42 2021
[GH] [FragmentStrictMode] Detect wrong Fragment container usage
## Proposed Changes
- Detect usage of `Fragment` containers other than `FragmentContainerView`
## Testing
Test: See `FragmentStrictModeTest#detectWrongFragmentContainer`
## Issues Fixed
Fixes: 181137036
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/146 .
Resolves #146
Github-Pr-Head-Sha: cd84de8a730000607984f21aefb9f6124b4d80a2
GitOrigin-RevId: 02bc1945a1a4cd5d2810eccd9ffa71e3247286a6
Change-Id: I86d8f2797c4e76957b36c31e91fb474e42c9ee1d
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.java
https://android-review.googlesource.com/1656242
Branch: androidx-main
commit df2d4fd54fbf766df31c1a07c33464ece5872783
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 29 14:48:42 2021
[GH] [FragmentStrictMode] Detect wrong Fragment container usage
## Proposed Changes
- Detect usage of `Fragment` containers other than `FragmentContainerView`
## Testing
Test: See `FragmentStrictModeTest#detectWrongFragmentContainer`
## Issues Fixed
Fixes: 181137036
This is an imported pull request from
Resolves #146
Github-Pr-Head-Sha: cd84de8a730000607984f21aefb9f6124b4d80a2
GitOrigin-RevId: 02bc1945a1a4cd5d2810eccd9ffa71e3247286a6
Change-Id: I86d8f2797c4e76957b36c31e91fb474e42c9ee1d
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.java
Description
Allow developers to detect when they are using a container for their fragments other than the recommended
FragmentContainerView.This would apply to any Fragment that was added with a
containerViewId(i.e., via the respective methods onFragmentTransaction). It would not apply to headless fragments / fragments added without a container ID.