Please make 'name' field of NamedNavArgument class public [181320559]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

f....@gmail.com

created issue #1

Feb 27, 2021 08:46AM

Component: navigation-compose 1.0.0-alpha08

Hi there, I am trying to migrate to the Compose flavour of Navigation, and working with the NamedNavArgument class. I'd like to be able to retrieve the name that I passed in to the navArgument() function, but it's a bit hard because the name field is private in NamedNavArgument.

Can you please make this field public? Since the class is basically an immutable data class, it seems natural to be able to access its fields publicly.

Comments

il...@google.com <il...@google.com> #2Mar 1, 2021 06:21PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3531312

Convert navigation-testing to KMP

Expand for full commit details

Convert navigation-testing to KMP 
 
Moving the navigation-testing module to KMP. This supports all the same 
platforms as the rest of Navigation and has converted all uses of Bundle 
to the new SaveState. 
 
RelNote: "Navigation Testing is now a KMP module." 
Test: all tests pass 
Bug: 398265336 
Change-Id: I2b7707a56f263be30420cae57e3b38480d7f0625

Files:

M docs-tip-of-tree/build.gradle
A navigation/navigation-testing/bcv/native/current.txt
M navigation/navigation-testing/build.gradle
M navigation/navigation-testing/src/androidInstrumentedTest/AndroidManifest.xml
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavHostControllerTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavigatorStateTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/res/navigation/test_graph.xml
M navigation/navigation-testing/src/androidMain/AndroidManifest.xml
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavHostController.android.kt
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavigatorState.android.kt
A navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/RobolectricTest.android.kt
M navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt
A navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/SavedStateHandleFactory.kt
M navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/TestNavigatorProvider.kt
D navigation/navigation-testing/src/main/AndroidManifest.xml
D navigation/navigation-testing/src/main/java/androidx/navigation/testing/SavedStateHandleFactory.kt

Hash: 31ae4c7ebb13918db0e022b19246b7a47755ac65
Date: Fri Mar 07 09:11:14 2025

f....@gmail.com <f....@gmail.com> #3Mar 2, 2021 07:33AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3545603

Implement jvmTest for navigation-testing

Expand for full commit details

Implement jvmTest for navigation-testing 
 
Adding a copy of TestSavedStateHandleFactory to jvmCommonTest to ensure 
that is runs on all nonAndroid platforms. 
 
The `nullLiteralArgument` and `emptyStringArgument` tests are expected 
to fail as they require the encoding and decoding the types which is 
behavior only supported on the jetbrains fork. 
 
Test: added tests 
Bug: 398265336 
Change-Id: I4c1dcfb697d6e9e16995b249b9a8351bd925e0f3

Files:

M navigation/navigation-testing/build.gradle
A navigation/navigation-testing/src/jvmCommonTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt

Hash: 139d2423c7625f19ececc94b2df5bfde24e2cf95
Date: Fri Mar 14 23:48:06 2025

f....@gmail.com <f....@gmail.com> #4Mar 2, 2021 07:38AM

This way my NavGraph can be constructed with a for loop:

 val mainGraph = NavHost(controller, startDestination = Destinations.dayPager.route) {
    for (dest in Destinations.destinations) {
        composable(dest.route, dest.mandatoryArgs + dest.optionalArgs) {
                dest.composableEntryPoint(...)
        }
    }
}

il...@google.com <il...@google.com> #5May 5, 2021 12:44AM

Assigned to jb...@google.com.

I think it makes sense to expose these as public vals and also make the destructuring methods public.

ap...@google.com <ap...@google.com> #6May 6, 2021 03:46PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 595a8c462a221546cf2c622c28d0252204a28328
Author: Jossi Wolf <10628007+jossiwolf@users.noreply.github.com>
Date: Wed May 05 20:26:42 2021

[GH] [Navigation] Make NamedNavArgument's fields public

## Proposed Changes

Relnote: NamedNavArgument's `name`, `argument` and destructuring functions are now public

## Testing

Test: N/A

## Issues Fixed

Fixes:

b/181320559

This is an imported pull request from

https://github.com/androidx/androidx/pull/174.

Resolves #174
Github-Pr-Head-Sha: 4343fabab030f5a754d104eacf8fc4f2b8e0087c
GitOrigin-RevId: 59a1b48dfdc98cdb59fedc8759005e8e862332f8
Change-Id: I03782da5f97d1fcd461ae017ac28be6c1c7dc7f5

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NamedNavArgument.kt

https://android-review.googlesource.com/1697765

Issue 181320559