Please make 'name' field of NamedNavArgument class public [181320559]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

f....@gmail.com

created issue #1

Feb 27, 2021 08:46AM

Component: navigation-compose 1.0.0-alpha08

Hi there, I am trying to migrate to the Compose flavour of Navigation, and working with the NamedNavArgument class. I'd like to be able to retrieve the name that I passed in to the navArgument() function, but it's a bit hard because the name field is private in NamedNavArgument.

Can you please make this field public? Since the class is basically an immutable data class, it seems natural to be able to access its fields publicly.

Comments

il...@google.com <il...@google.com> #2Mar 1, 2021 06:21PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

f....@gmail.com <f....@gmail.com> #3Mar 2, 2021 07:33AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

f....@gmail.com <f....@gmail.com> #4Mar 2, 2021 07:38AM

deleted

il...@google.com <il...@google.com> #5May 5, 2021 12:44AM

Assigned to jb...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6May 6, 2021 03:46PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 595a8c462a221546cf2c622c28d0252204a28328
Author: Jossi Wolf <10628007+jossiwolf@users.noreply.github.com>
Date: Wed May 05 20:26:42 2021

[GH] [Navigation] Make NamedNavArgument's fields public

## Proposed Changes

Relnote: NamedNavArgument's `name`, `argument` and destructuring functions are now public

## Testing

Test: N/A

## Issues Fixed

Fixes:

b/181320559

This is an imported pull request from

https://github.com/androidx/androidx/pull/174.

Resolves #174
Github-Pr-Head-Sha: 4343fabab030f5a754d104eacf8fc4f2b8e0087c
GitOrigin-RevId: 59a1b48dfdc98cdb59fedc8759005e8e862332f8
Change-Id: I03782da5f97d1fcd461ae017ac28be6c1c7dc7f5

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NamedNavArgument.kt

https://android-review.googlesource.com/1697765

Issue 181320559