Fixed
Status Update
No update yet.
Comments
il...@google.com
since these are in public API (:/) we need to do this in 1.2
f....@gmail.com
since it is already marked as deprecated, we can probably do it by now.
f....@gmail.com
Opening diff shortly
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 595a8c462a221546cf2c622c28d0252204a28328
Author: Jossi Wolf <10628007+jossiwolf@users.noreply.github.com>
Date: Wed May 05 20:26:42 2021
[GH] [Navigation] Make NamedNavArgument's fields public
## Proposed Changes
Relnote: NamedNavArgument's `name`, `argument` and destructuring functions are now public
## Testing
Test: N/A
## Issues Fixed
Fixes:
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/174 .
Resolves #174
Github-Pr-Head-Sha: 4343fabab030f5a754d104eacf8fc4f2b8e0087c
GitOrigin-RevId: 59a1b48dfdc98cdb59fedc8759005e8e862332f8
Change-Id: I03782da5f97d1fcd461ae017ac28be6c1c7dc7f5
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NamedNavArgument.kt
https://android-review.googlesource.com/1697765
Branch: androidx-main
commit 595a8c462a221546cf2c622c28d0252204a28328
Author: Jossi Wolf <10628007+jossiwolf@users.noreply.github.com>
Date: Wed May 05 20:26:42 2021
[GH] [Navigation] Make NamedNavArgument's fields public
## Proposed Changes
Relnote: NamedNavArgument's `name`, `argument` and destructuring functions are now public
## Testing
Test: N/A
## Issues Fixed
Fixes:
This is an imported pull request from
Resolves #174
Github-Pr-Head-Sha: 4343fabab030f5a754d104eacf8fc4f2b8e0087c
GitOrigin-RevId: 59a1b48dfdc98cdb59fedc8759005e8e862332f8
Change-Id: I03782da5f97d1fcd461ae017ac28be6c1c7dc7f5
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NamedNavArgument.kt
Description
Component: navigation-compose 1.0.0-alpha08
Hi there, I am trying to migrate to the Compose flavour of Navigation, and working with the
NamedNavArgumentclass. I'd like to be able to retrieve the name that I passed in to thenavArgument()function, but it's a bit hard because thenamefield is private inNamedNavArgument.Can you please make this field public? Since the class is basically an immutable data class, it seems natural to be able to access its fields publicly.