Fixed
Status Update
No update yet.
Comments
il...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ku...@gmail.com
yea i'll take it.
jb...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
jb...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
Description
Component used: Fragment
Version used:
Devices/Android versions reproduced on: any
When using a `DialogFragment`, the `setOnCancelListener` and `setOnDismissListener` callback functions within the `onCreateDialog` function should not be used as the `DialogFragment` owns these callbacks. Instead the respective `onCancel` and `onDismiss` functions on `DialogFragment` can be overriden to achieve the desired effect.
While this is currently called out via a comment on the `onCreateDialog` function, a lint warning might better inform developers of this potential gotcha.