Fixed
Status Update
No update yet.
Comments
il...@google.com
Building note: run ./gradlew ... -x processReleaseMetadata
ku...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018
Fix ViewModel proguard rules
It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection
Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c
M lifecycle/viewmodel/proguard-rules.pro
https://android-review.googlesource.com/727573
https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38
Branch: androidx-master-dev
commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018
Fix ViewModel proguard rules
It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection
Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c
M lifecycle/viewmodel/proguard-rules.pro
jb...@google.com
I had the similar problem. Hoping the problem will be fixed in the next release. Thank team!
Description
Component used: Fragment
Version used:
Devices/Android versions reproduced on: any
When using a `DialogFragment`, the `setOnCancelListener` and `setOnDismissListener` callback functions within the `onCreateDialog` function should not be used as the `DialogFragment` owns these callbacks. Instead the respective `onCancel` and `onDismiss` functions on `DialogFragment` can be overriden to achieve the desired effect.
While this is currently called out via a comment on the `onCreateDialog` function, a lint warning might better inform developers of this potential gotcha.