NullSafeMutableLiveData lint doesn't work when field have modifiers [183696616]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Mar 25, 2021 02:14PM

Component used:
Version used: 2.3.1

```
class MyClass {
internal val liveDataField = MutableLiveData<Boolean>()

fun foo() {
liveDataField.value = false
liveDataField.value = null
}
}
```

Comments

se...@google.com <se...@google.com> Mar 25, 2021 02:23PM

Reassigned to jb...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Mar 25, 2021 03:17PM

apologies, i meant "navigate(To...)"

ap...@google.com <ap...@google.com> #3Mar 30, 2021 10:47AM

Marked as fixed.

Yep, it appears that navigateUp() returns true, even when nothing visually changes on the screen. This seems to be caused by popBackStack(), which is always returning true even when popping the root Fragment.

mi...@gmail.com <mi...@gmail.com> #4Apr 2, 2021 03:28AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 77f6f126b51ef6c880368ed5b4ac900c7b187165
Author: Ian Lake <ilake@google.com>
Date: Wed Feb 06 10:03:44 2019

Fix popBackStack logic when popping the root destination

popBackStack() and by extension navigateUp() should
only return true if the user was successfully navigated
to a new destination. In cases where the entire stack
was popped, the methods should return false so that
additional logic, such as finishing the activity, can
be employed.

This fixes a regression introduced in

https://issuetracker.google.com/issues/123552990

Test: updated tests
BUG: 123933201
Change-Id: I756481f14b2c7d9b8f401bea05c4dbd16d28f614

M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/896574

https://goto.google.com/android-sha1/77f6f126b51ef6c880368ed5b4ac900c7b187165

mi...@gmail.com <mi...@gmail.com> #5Apr 12, 2021 10:58PM

This is fixed and will be available in Navigation 1.0.0-beta02.

mi...@gmail.com <mi...@gmail.com> #6Jun 2, 2021 02:24AM

Hi, I hate to keep posting same comments, but are there any plans to release this fix? It's blocking us from updating to fragment 1.3.2+.

ja...@gmail.com <ja...@gmail.com> #7Feb 23, 2022 05:25AM

c0...@gmail.com <c0...@gmail.com> #8May 16, 2022 03:50AM

How do you update components that are viewed through the chrome.url page of they all indicate that they are not up to date

c0...@gmail.com <c0...@gmail.com> #9May 16, 2022 03:52AM

Also my phone was in the hands of a skilled IT individual, how can I verify what, if any, modifications took place. I cannot enter recovery mode on my device....