NullSafeMutableLiveData lint doesn't work when field have modifiers [183696616]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Mar 25, 2021 02:14PM

Component used:
Version used: 2.3.1

```
class MyClass {
internal val liveDataField = MutableLiveData<Boolean>()

fun foo() {
liveDataField.value = false
liveDataField.value = null
}
}
```

Comments

se...@google.com <se...@google.com> Mar 25, 2021 02:23PM

Reassigned to jb...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Mar 25, 2021 03:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66494e2d6810347e6a3b41ec3f2665e598f108f0
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 14 00:14:24 2022

Ensure that SavedStateHandle restores upon initial creation

runOnNextRecreation() only runs on the next time
the lifecycle reaches CREATED, not the first time.

By using a LifecycleObserver directly, we ensure that
each Lifecycle move causes a performRestore() to
consistently happen.

Test: existing tests pass, sample app works
BUG: 228865698
Relnote: "Fixed an issue where nesting one `NavHost` within
another `NavHost` in a non-primary bottom navigation tab
would lead to an `IllegalStateException` when using
multiple back stacks."

Change-Id: I11bd5173f035ae1da7922b4142fcedc0f3b54ff6

M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt

https://android-review.googlesource.com/2064518

ap...@google.com <ap...@google.com> #3Mar 30, 2021 10:47AM

Marked as fixed.

Thanks for quick fix! Works well with latest snapshot.

mi...@gmail.com <mi...@gmail.com> #4Apr 2, 2021 03:28AM

Thanks for confirming! The fix will be in the next release of Lifecycle (2.5.0-beta01).

mi...@gmail.com <mi...@gmail.com> #5Apr 12, 2021 10:58PM

2.4.1 also has same issue

using jetpack compose / bottom navigation with NavHost

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

mi...@gmail.com <mi...@gmail.com> #6Jun 2, 2021 02:24AM

I am seeing a high occurance rate with 2.5.0-beta01 as well.

ja...@gmail.com <ja...@gmail.com> #7Feb 23, 2022 05:25AM

Re comment#5 and comment#6 - please file a new bug with a sample project that reproduces your issue. That would help rule out it being a duplicate of this issue where your remember around getBackStackEntry needs to be updated.

c0...@gmail.com <c0...@gmail.com> #8May 16, 2022 03:50AM

Hi, I recently came across this crash in my current project and I discovered that it happens when a Textfield was tapped and in focus, then the app was backgrounded. This would occur with all of the Textfields in the app.

We are using Compose version: 1.2.0-rc03
and jetpack lifecycle version: 2.4.1

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

c0...@gmail.com <c0...@gmail.com> #9May 16, 2022 03:52AM

Please file a new bug with a minimal sample project that reproduces your error.