NullSafeMutableLiveData lint doesn't work when field have modifiers [183696616]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Mar 25, 2021 02:14PM

Component used:
Version used: 2.3.1

```
class MyClass {
internal val liveDataField = MutableLiveData<Boolean>()

fun foo() {
liveDataField.value = false
liveDataField.value = null
}
}
```

Comments

se...@google.com <se...@google.com> Mar 25, 2021 02:23PM

Reassigned to jb...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Mar 25, 2021 03:17PM

This requirement for addObserver to be called on the main thread is part of the Lifecycle 2.3.0-alpha06 release notes, which Fragment/Activity depend on:

LifecycleRegistry now verifies that its methods are called on main thread. It was always a requirement for lifecycles of activities, fragments etc. An addition of observers from non-main threads resulted in hard to catch crashes in runtime.

It affects all APIs that use Lifecycle, including Navigation.

ap...@google.com <ap...@google.com> #3Mar 30, 2021 10:47AM

Marked as fixed.

Thanks! Somehow I've missed that.

mi...@gmail.com <mi...@gmail.com> #4Apr 2, 2021 03:28AM

Project: platform/frameworks/support
Branch: androidx-main

commit 76230d4cbcf193ad3c01e2fb317a1bb3c571b1de
Author: Ian Lake <ilake@google.com>
Date: Tue Apr 06 12:53:25 2021

Mark navigate/setGraph as @MainThread

With the upgrade to Lifecycle 2.3.1,
Lifecycle now enforces that all creation and
changes to the Lifecycle state (including adding
and removing observers) should be done on the
main thread.

By marking navigate() and setGraph() as
`@MainThread`, we can give developeres better
visibility that these operations should only
be done on the main thread.

Relnote: "Navigation now depends on
[Lifecycle `2.3.1`](/jetpack/androidx/releases/lifecycle#2.3.1)
and now marks `setGraph()` and `navigate()`, the
methods that update the `NavBackStackEntry` `Lifecycle`,
as `@MainThread`, aligning Navigation with the main thread
enforcement introduced in Lifecycle `2.3.0`."
Test: existing and updated tests pass
BUG: 171125856

Change-Id: Ifcbe407d9cb186b50f05cbbd8bc5e11e19115a82

M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/build.gradle
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1665821

mi...@gmail.com <mi...@gmail.com> #5Apr 12, 2021 10:58PM

For the upcoming Navigation 2.4.0-alpha01 release, we've made it explicit that setGraph() and navigate() should only be called on the main thread (by adding @MainThread annotations to the methods), thus aligning with the main thread enforcement of Lifecycle 2.3.

mi...@gmail.com <mi...@gmail.com> #6Jun 2, 2021 02:24AM

Project: platform/frameworks/support
Branch: androidx-main

commit 00c608a86c44b066198bd8c1dc7e2aef6088d4e1
Author: Ian Lake <ilake@google.com>
Date: Mon Apr 12 14:04:54 2021

Mark popBackStack and navigateUp as @MainThread

In addition to the navigate() and setGraph()
methods updated in

https://android-review.googlesource.com/1665821
the methods for popping the back stack
should also be marked as @MainThread.

Relnote: "Navigation now depends on
[Lifecycle `2.3.1`](/jetpack/androidx/releases/lifecycle#2.3.1)
and now marks all of the methods that update the
`NavBackStackEntry` `Lifecycle`, including `setGraph()`,
`navigate()`, `popBackStack()`, and `navigateUp()`,
as `@MainThread`, aligning Navigation with the main thread
enforcement introduced in Lifecycle `2.3.0`."
Test: existing and updated tests pass
BUG: 171125856

Change-Id: Ib8bedbb3fe384b28c7441cbd57a0751eba307a2b

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1673448

ja...@gmail.com <ja...@gmail.com> #7Feb 23, 2022 05:25AM

c0...@gmail.com <c0...@gmail.com> #8May 16, 2022 03:50AM

How do you update components that are viewed through the chrome.url page of they all indicate that they are not up to date

c0...@gmail.com <c0...@gmail.com> #9May 16, 2022 03:52AM

Also my phone was in the hands of a skilled IT individual, how can I verify what, if any, modifications took place. I cannot enter recovery mode on my device....