NullSafeMutableLiveData lint doesn't work when field have modifiers [183696616]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Mar 25, 2021 02:14PM

Component used:
Version used: 2.3.1

```
class MyClass {
internal val liveDataField = MutableLiveData<Boolean>()

fun foo() {
liveDataField.value = false
liveDataField.value = null
}
}
```

Comments

se...@google.com <se...@google.com> Mar 25, 2021 02:23PM

Reassigned to jb...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Mar 25, 2021 03:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d0a10be065a3a629e3835f28d35804c91d8d2e4d
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1427352

ap...@google.com <ap...@google.com> #3Mar 30, 2021 10:47AM

Marked as fixed.

We've updated the error message to make it more clear what destination you're currently on - this will help you determine if your call to setGraph() hasn't happened yet (you have a null current destination) or if you've popped to another destination unexpectedly.

mi...@gmail.com <mi...@gmail.com> #4Apr 2, 2021 03:28AM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513

commit 6ada6bd039f4a28d2760f4912093abc60ab54d84
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436733

mi...@gmail.com <mi...@gmail.com> #5Apr 12, 2021 10:58PM

Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533

commit e5780347bfba28e4a500bd964d273c282c12dceb
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436737

mi...@gmail.com <mi...@gmail.com> #6Jun 2, 2021 02:24AM

Project: platform/frameworks/support
Branch: snap-temp-L46100000699831674

commit 7ab7f8b1967945ba0d506120dbc070ecbfb37c13
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436741

ja...@gmail.com <ja...@gmail.com> #7Feb 23, 2022 05:25AM

Project: platform/frameworks/support
Branch: snap-temp-L91000000699844097

commit 4101ca222554fdfae678ff1e6e47b1a4ab319a56
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436542

c0...@gmail.com <c0...@gmail.com> #8May 16, 2022 03:50AM

Project: platform/frameworks/support
Branch: snap-temp-L34200000699848945

commit 0da3ed71fa5545646d44fb44219b31e7e5621f8f
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436745

c0...@gmail.com <c0...@gmail.com> #9May 16, 2022 03:52AM

Project: platform/frameworks/support
Branch: snap-temp-L04700000699849955

commit 12b13608ec1155b5780fe44f5ab07cdc93c5ba90
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436750