NonNullableMutableLiveDataDetector doesn't work in different cases [184830263]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 8, 2021 03:18PM

Component used: lifecycle lint Version used: 2.3.1 Devices/Android versions reproduced on:

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // Lint gives error about this line

}

If I remove <String> from initialization, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

If I remove private modifier, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

MutableLiveDataLintFail 2.zip

1.2 MB

Download

Comments

se...@google.com <se...@google.com> Apr 8, 2021 03:21PM

Reassigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Apr 8, 2021 03:22PM

To use Lifecycle 2.8.0-alpha03, ensure you are using at least Compose UI 1.7.0-alpha05.

The issue is happening because, starting from Lifecycle 2.8.0-alpha03 and Compose UI 1.7.0-alpha05, LocalLifecycleOwner has been moved from androidx.compose.ui to lifecycle-runtime-compose, as outlined in their respective release notes. For compatibility reasons, you must update both dependencies.

For context, note these changes were made to enable the utilization of its Compose-based helper APIs beyond Compose UI (such as in Molecule). Further information can be found at b/328263448.

If the issue persists even after updating your Compose UI, please let us know.

Edit: please see https://issuetracker.google.com/336842920#comment8 for a workaround.

ko...@gmail.com <ko...@gmail.com> #3Apr 17, 2021 11:14AM

Thanks for your answer.
If this change has made both libraries version dependent, it seems that guide them to the release note so that users will not experience difficulties :)

ap...@google.com <ap...@google.com> #4May 6, 2021 03:47PM

Marked as fixed.

lifecycle 2.8.0 is now stable but compose UI 1.7.0 is still in beta.

pa...@gmail.com <pa...@gmail.com> #5Jan 4, 2022 10:57PM

Same problem here. Lifecycle 2.8.0 is now stable but Compose UI 1.7.0 is still beta. Of course our Dependabot didn't know about this relationship between dependencies 😬

Issue 184830263