NonNullableMutableLiveDataDetector doesn't work in different cases [184830263]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 8, 2021 03:18PM

Component used: lifecycle lint Version used: 2.3.1 Devices/Android versions reproduced on:

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // Lint gives error about this line

}

If I remove <String> from initialization, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

If I remove private modifier, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

MutableLiveDataLintFail 2.zip

1.2 MB

Download

Comments

se...@google.com <se...@google.com> Apr 8, 2021 03:21PM

Reassigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Apr 8, 2021 03:22PM

Can you include a sample project that crashes in release mode?

ko...@gmail.com <ko...@gmail.com> #3Apr 17, 2021 11:14AM

For us this is only happening in places where LifecycleEventEffect is used. Example stacktrace:

Fatal Exception: java.lang.IllegalStateException
CompositionLocal LocalLifecycleOwner not present
androidx.lifecycle.compose.LocalLifecycleOwnerKt$LocalLifecycleOwner$1$1.invoke (LocalLifecycleOwner.android.kt:63)
androidx.lifecycle.compose.LocalLifecycleOwnerKt$LocalLifecycleOwner$1$1.invoke (LocalLifecycleOwner.android.kt:62)
kotlin.SynchronizedLazyImpl.getValue (LazyJVM.kt:74)
androidx.compose.runtime.LazyValueHolder.getCurrent (LazyValueHolder.java:29)
androidx.compose.runtime.LazyValueHolder.getValue (LazyValueHolder.java:31)
androidx.compose.runtime.CompositionLocalMapKt.read (CompositionLocalMap.kt:90)
androidx.compose.runtime.ComposerImpl.consume (Composer.kt:2135)
androidx.lifecycle.compose.LifecycleEffectKt.LifecycleEventEffect (LifecycleEffect.kt:748)
com.freeletics.feature.profile.ProfileUiKt$ProfileUi$1.invoke (ProfileUi.kt:62)

This is also on Lifecycle 2.8.2 with Compose 1.6.

ap...@google.com <ap...@google.com> #4May 6, 2021 03:47PM

Marked as fixed.

Here is a sample project

https://github.com/nilsjr/Koncept

Checkout repository
Build release apk with ./gradlew :app:assembleRelease -PenableReleaseSigning=true
App starts without crash
Comment or remove line 14 in https://github.com/nilsjr/Koncept/blob/develop/app/proguard-rules.pro
Build release apk with ./gradlew :app:assembleRelease -PenableReleaseSigning=true
App crashing on start

FATAL EXCEPTION: main (Ask Gemini)
  Process: de.nilsdruyen.koncept, PID: 5880
  java.lang.IllegalStateException: CompositionLocal LocalLifecycleOwner not present
  ...

pa...@gmail.com <pa...@gmail.com> #5Jan 4, 2022 10:57PM

comment#4:

Thank you for sharing the sample project. I can confirm that I was able to reproduce the issue, and that your workaround works. I will investigate the problem further.

Issue 184830263