NonNullableMutableLiveDataDetector doesn't work in different cases [184830263]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 8, 2021 03:18PM

Component used: lifecycle lint Version used: 2.3.1 Devices/Android versions reproduced on:

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // Lint gives error about this line

}

If I remove <String> from initialization, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

If I remove private modifier, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

MutableLiveDataLintFail 2.zip

1.2 MB

Download

Comments

se...@google.com <se...@google.com> Apr 8, 2021 03:21PM

Reassigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Apr 8, 2021 03:22PM

Which device is issue being reported on? Can you get any logs from the device for us after you turn on verbose logging ?

ko...@gmail.com <ko...@gmail.com> #3Apr 17, 2021 11:14AM

A few things in addition to the questions in #2:

1. Can you verify that this problem still occurs in beta03? This is available now.
2. Can you check your merged manifest has a network permission (ACCESS_NETWORK_STATE)? It should get merged in automatically.

ap...@google.com <ap...@google.com> #4May 6, 2021 03:47PM

Marked as fixed.

#3: have now tried beta03 and it's the same behaviour... periodic work schedule breaks down when network constraint is applied (after a period of time with no network). And yes, ACCESS_NETWORK_STATE is in the merged manifest... it's actually in the main manifest anyway.

#2: I'll try...

pa...@gmail.com <pa...@gmail.com> #5Jan 4, 2022 10:57PM

Re #2 getting logs... I have tried previously to get logs from the user, and on each occasion the logs started *after* the point of interest, as if the logs had been cleared just before (e.g. just after a problem), so they've not been of any use.

The way I'm getting logs is via a button in the widget configuration activity which runs the following:

Runtime.getRuntime().exec("logcat -f " + logFile + " *:V");

Is there a better way of getting logs from a user (where the user is not an advanced user and can only just about handle pressing a button and sending a text file)?

Issue 184830263