NonNullableMutableLiveDataDetector doesn't work in different cases [184830263]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 8, 2021 03:18PM

Component used: lifecycle lint Version used: 2.3.1 Devices/Android versions reproduced on:

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // Lint gives error about this line

}

If I remove <String> from initialization, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

If I remove private modifier, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

MutableLiveDataLintFail 2.zip

1.2 MB

Download

Comments

se...@google.com <se...@google.com> Apr 8, 2021 03:21PM

Reassigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Apr 8, 2021 03:22PM

After creating the issue I've noticed that I mixed up a few terms, sorry about that. JobService should be JobScheduler. When referring to jobs in the description, those are classes extending Worker.

ko...@gmail.com <ko...@gmail.com> #3Apr 17, 2021 11:14AM

We have a large set of users seeing this same issue... I can confirm that it seems to only effect users using Android OS 4.4 - 5.1. We are also using WorkManager 2.0.0

ap...@google.com <ap...@google.com> #4May 6, 2021 03:47PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 098c163581a360c32baa6e4c215227f0efd10889
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Mar 25 14:05:34 2019

Reset WorkConstraintsTracker when cleaning up in DelayMetCommandHandler.

* DelayMetCommandHandler would previously not cleanup correctly and WorkConstraintsTracker
would trigger callbacks without going through the SystemAlarmDispatcher lifecycle
of processing a command.

Fixes:

b/129226383

Test: Added a unit test.
Change-Id: Id2aaf0cce7c4a1a4526a25a211f3fe0551dbe557

M work/workmanager/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java

https://android-review.googlesource.com/933140

https://goto.google.com/android-sha1/098c163581a360c32baa6e4c215227f0efd10889

pa...@gmail.com <pa...@gmail.com> #5Jan 4, 2022 10:57PM

Great to see such a quick fix. Do you have any estimate when a new version that includes this change will be released?

Issue 184830263