NonNullableMutableLiveDataDetector doesn't work in different cases [184830263]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 8, 2021 03:18PM

Component used: lifecycle lint Version used: 2.3.1 Devices/Android versions reproduced on:

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // Lint gives error about this line

}

If I remove <String> from initialization, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

If I remove private modifier, lint doesn't fail. This is not an error.

private val liveData: MutableLiveData<String> = MutableLiveData<String>("Some string")

init {
  liveData.value = null // This is OK but lint should have failed
}

MutableLiveDataLintFail 2.zip

1.2 MB

Download

Comments

se...@google.com <se...@google.com> Apr 8, 2021 03:21PM

Reassigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Apr 8, 2021 03:22PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ko...@gmail.com <ko...@gmail.com> #3Apr 17, 2021 11:14AM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

ap...@google.com <ap...@google.com> #4May 6, 2021 03:47PM

Marked as fixed.

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

pa...@gmail.com <pa...@gmail.com> #5Jan 4, 2022 10:57PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

Issue 184830263