Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit df4b3e976b54c76a3b1178b9543402605f27711c
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed May 19 21:44:33 2021
Override fitSystemWindows in FragmentContainerView
Updating API in FragmentContainerView to override
fitSystemWindows() and throw an exception informing
user that if they would like to handle insets, they
should do so at each individual fragment view.
RelNote: "`FragmentContainerView` now overrides
`fitSystemWindows()` and throws exception to inform
user to handle inserts in individual fragment views."
Bug: 187304502
Test: ./gradlew checkApi
Change-Id: Ie6651e5de15e2f99f3a6c9fe1554928f34821782
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
https://android-review.googlesource.com/1712868
Branch: androidx-main
commit df4b3e976b54c76a3b1178b9543402605f27711c
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed May 19 21:44:33 2021
Override fitSystemWindows in FragmentContainerView
Updating API in FragmentContainerView to override
fitSystemWindows() and throw an exception informing
user that if they would like to handle insets, they
should do so at each individual fragment view.
RelNote: "`FragmentContainerView` now overrides
`fitSystemWindows()` and throws exception to inform
user to handle inserts in individual fragment views."
Bug: 187304502
Test: ./gradlew checkApi
Change-Id: Ie6651e5de15e2f99f3a6c9fe1554928f34821782
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
sa...@google.com
il...@google.com
This behavior has been changed for Fragment 1.4.0-alpha02 - FragmentContainerView was always meant to purely pass insets down to all fragments. It is then up to each Fragment on how they want to handle insets by applying fitsSystemWindows="true" to their root layout or not.
Description
Wehttps://android-review.googlesource.com/c/platform/frameworks/support/+/985243/ ensured that unlike
FragmentContainerViewwas created,FragmentLayoutthat consumed all of the insets when usingfitSystemWindows=true,FragmentContainerViewwould always dispatch the insets to child views, regardless of the value.Now for
FragmentContainerViewfitSystemWindows=trueis a no-op, but we should instead throw an error and indicate to the user that if they would like to handle insets they should do so at each individual fragment view.