DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

This was fixed by aosp/1331903 and will be available in the Lifecycle 2.3.0-alpha04 release.

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f891d66d44417ae7298d8306dc5cbca9cfe4b1ee
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jul 08 14:20:29 2020

Fix lifecycle-livedata-core-ktx-lint ObsoleteLintCustomCheck

Using the latest version of lint-core (27.1.0) as a dependency for the
livedata-core lint rule causes an ObsoleteLintCustomCheck for studio 4.0
and 4.1 (along with the subsequent gradle versions).

Instead of using the latest, using the minimum version seems to work
appropriately.

Added a lintMinVersion variable to the dependcies file and used that to
make updating easier.

Test: tested in studio 4.0 and 4.1-Canary 8
Bug: 158699265
Change-Id: If1636b3e08a368cf25fb268f42754c4c6ff2f463

M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/build.gradle

https://android-review.googlesource.com/1358530

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

There was a use of a lint version that was too new to work in older studio versions. This has now be fixed and will be released in the Lifecycle 2.3.0-alpha06 release.

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

Getting this again in AGP 8.2.2 and Gradle 8.6, please see the attached image file.

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

Just found out that the issue comes after updating androidx.lifecycle:lifecycle-livedata-ktx from 2.7.0 to 2.8.0.

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

Using AGP 8.5.1 with Gradle 8.7 makes the latest occurrence of this go away for me (with androidx.lifecycle:lifecycle-runtime-ktx 2.8.4).

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing