DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

yea i'll take it.

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing