DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

Hey, I would like to take this up?

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

Hey, any help on how can I proceed forward.?

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

Re #2,3 - We've just published our guide to writing custom Lint rules, which should walk you through the steps required to write this Lint check.

Fragment have some existing lint checks in their fragment-lint project, so some of the steps are already taken care of for you (and the existing Lint checks are a good place to look for code examples and testing strategies).

Thanks for offering to help!

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

https://github.com/androidx/androidx/pull/156 PR is ready for this ticket

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

Thank you for the pull request! This has been added internally and will be a part of the next Fragment alpha release.

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

I know the ticket is closed but ..
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing