DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

Not all of our builds depend on androidx.fragment and if you do not use androidx.fragment and you add this disable flag, lint fails due to non-existant check DialogFragmentCallbacksDetector. If you do not plan on fixing this soon, I can try and see if we can only disable the check if we depend on androidx.fragment.

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit 52b166175eabed99d14515190bfa0a7cea787004
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 16:11:44 2021

Fix OnCreateDialogIncorrectCallback lint on empty java classes

The OnCreateDialogIncorrectCallbackDetector lint rule currently checks
the first element of a list without verifying the item is actually
there. We should check if the item is null before we do anything else.

RelNote: "The `OnCreateDialogIncorrectCallbackDetector` no longer fails
on empty java classes/interfaces"
Test: java empty interface clean
Bug: 187524311

Change-Id: Iaff6c041370bd5a7c2ac8ef8c32a2e6f7a15e456

M fragment/fragment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
M fragment/fragment-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt

https://android-review.googlesource.com/1702325

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.4.0-alpha01 release.

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

I am using 1.4.0-alpha01 of the Fragment Library but I am still getting this error.

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

Re #6 - please file a new bug with a sample that reproduces your error.

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing