[Lint] repeatOnLifecycle used in onStart/onStop [187887400]

Fixed

Feature Request

Status Update

No update yet.

Description

mv...@google.com

created issue #1

May 12, 2021 06:23AM

Warn developers when Lifecycle.repeatOnLifecycle is not used properly.

They should definitely NOT be used in the onStart, onResume View callbacks. In Activities, this API should be used in the onCreate. onViewCreated in the case of Fragments.

Comments

ap...@google.com <ap...@google.com> #2May 24, 2021 11:11AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 706078c215107f5cde51b66233dd0158bca729dc
Author: Manuel Vivo <mvivo@google.com>
Date: Wed May 12 16:12:08 2021

Add lint checks to repeatOnLifecycle APIs

Fixes:

b/187887400

Change-Id: I4e50eacdfecc392b0343b862f5d63fcf20e72e1c

M lifecycle/lifecycle-runtime-ktx-lint/src/main/java/androidx/lifecycle/lint/LifecycleRuntimeIssueRegistry.kt
M lifecycle/lifecycle-runtime-ktx-lint/src/main/java/androidx/lifecycle/lint/LifecycleWhenChecks.kt
A lifecycle/lifecycle-runtime-ktx-lint/src/main/java/androidx/lifecycle/lint/RepeatOnLifecycleDetector.kt
A lifecycle/lifecycle-runtime-ktx-lint/src/test/java/androidx/lifecycle/lint/RepeatOnLifecycleDetectorTest.kt
M lifecycle/lifecycle-runtime-ktx-lint/src/test/java/androidx/lifecycle/lint/stubs/Stubs.kt

https://android-review.googlesource.com/1705341

Issue 187887400

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 24, 2021 11:11AM

Add comment

Issue metadata