Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1381476
Branch: androidx-master-dev
commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
Description
Warn developers when
Lifecycle.repeatOnLifecycle
is not used properly.They should definitely NOT be used in the
onStart
,onResume
View callbacks. In Activities, this API should be used in theonCreate
.onViewCreated
in the case of Fragments.