SafeArgs failing for older Kotlin versions [190739257]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of lc...@gmail.com #1

Jun 10, 2021 07:04PM

When using Navigation SafeArgs 2.4.0-alpha01+ with Kotlin versions before 1.5.0, you get the following:

Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at

* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'

This is because the titleCase API was not added until Kotlin 1.5.0.

In 2.4.0-alpha01+, SafeArgs must be compatible with AGP 4.2.0 and as a result Gradle 6.7.0, which is compatible with Kotlin versions prior to 1.5.0.

We should avoid using titlecase in SafeArgs until we no longer need to support older Kotlin versions. As a workaround, you can update your gradle version to 7.0+.

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2021 10:27PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: main

commit d9fcf3ac6751e611ab8a1970310ac6e7bf01f463
Author: Alec Bargher <abargher@google.com>
Date: Wed Aug 21 15:51:24 2024

dev-util: Add workaround for armv7a boards compiling LLDB

Currently armv7a is not parsed as a supported architecture by LLDB.
Compiling with the host architecture in the triple set to "arm" instead
of "armv7a" can work around this issue before LLDB itself is patched.

BUG=b:361414339
TEST=USE="local-lldb" cros build-packages --board=${BOARD}

Change-Id: I7c18ab9354b09fd91ac3635a8bcb4ac177f0d3cd
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5805607
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Alec Bargher <abargher@google.com>
Tested-by: Alec Bargher <abargher@google.com>
Commit-Queue: ChromeOS Auto Runner <chromeos-auto-runner@chromeos-bot.iam.gserviceaccount.com>

M dev-util/lldb-server/lldb-server-9999.ebuild

https://chromium-review.googlesource.com/5805607

jb...@google.com <jb...@google.com> #3Jun 10, 2021 10:31PM

Marked as fixed.

We should see if we can upstream a proper fix for this "armv7a" in particular is not an uncommon form in the target triple. Working on a patch now.

ma...@gmail.com <ma...@gmail.com> #4Nov 8, 2021 10:03AM

Upstream PR: https://github.com/llvm/llvm-project/pull/106433

de...@atommobility.com <de...@atommobility.com> #5Nov 17, 2021 12:44PM

Upstream PR merged! We just need to patch this down now, and we're all done.

jb...@google.com <jb...@google.com> #6Nov 17, 2021 04:08PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: main

commit a19a091eb14534ec05e14447677665111a635eaf
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Thu Aug 29 19:20:50 2024

llvm: Downstream armv7a, armv8a patch

armv7a and armv8a are common names for the application subarch for arm.

These names in particular are used in ChromeOS, Android, and a few other
known applications. In ChromeOS, we encountered a bug where armv7a arch
was not recognised and segfaulted when starting an executable on an
arm32 device.

Recreating this cl:
get_patch.py -s HEAD 0a00d32c5f88fce89006dcde6e235bc77d7b495e

BUG=b:361414339
TEST=Ran with lldb-hana under qemu-arm

Change-Id: I5af0f832bb657780232b59d8014133a25581ea2f
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5827378
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: Bob Haarman <inglorion@chromium.org>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

A dev-util/lldb-server/files/0a00d32c5f88fce89006dcde6e235bc77d7b495e.patch
M dev-util/lldb-server/files/PATCHES.json
M sys-devel/llvm/files/PATCHES.json
A sys-devel/llvm/files/cherry/0a00d32c5f88fce89006dcde6e235bc77d7b495e.patch

https://chromium-review.googlesource.com/5827378

th...@gmail.com <th...@gmail.com> #7Jan 27, 2022 12:44PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B

commit ead6651016c1015b4771244b390ab72630b9dea9
Author: Alec Bargher <abargher@google.com>
Date: Wed Aug 21 15:51:24 2024

dev-util: Add workaround for armv7a boards compiling LLDB

Currently armv7a is not parsed as a supported architecture by LLDB.
Compiling with the host architecture in the triple set to "arm" instead
of "armv7a" can work around this issue before LLDB itself is patched.

BUG=b:361414339
TEST=USE="local-lldb" cros build-packages --board=${BOARD}

(cherry picked from commit d9fcf3ac6751e611ab8a1970310ac6e7bf01f463)

Change-Id: I7c18ab9354b09fd91ac3635a8bcb4ac177f0d3cd
Original-Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5805607
Original-Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Original-Commit-Queue: Alec Bargher <abargher@google.com>
Original-Tested-by: Alec Bargher <abargher@google.com>
Original-Commit-Queue: ChromeOS Auto Runner <chromeos-auto-runner@chromeos-bot.iam.gserviceaccount.com>
GitOrigin-RevId: d9fcf3ac6751e611ab8a1970310ac6e7bf01f463
Cr-Build-Id: 8735988028124072689
Cr-Build-Url:

https://cr-buildbucket.appspot.com/build/8735988028124072689
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5885433
Reviewed-by: Grzegorz Bernacki <bernacki@google.com>
Owners-Override: Aaron Massey <aaronmassey@google.com>
Tested-by: Jonathon Murphy <jpmurphy@google.com>

M dev-util/lldb-server/lldb-server-9999.ebuild

https://chromium-review.googlesource.com/5885433

jb...@google.com <jb...@google.com> #8Jan 27, 2022 04:03PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B

commit 6bbde850cd778c4048a3e4b9cb445bc0442b87c6
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Thu Aug 29 19:20:50 2024

llvm: Downstream armv7a, armv8a patch

armv7a and armv8a are common names for the application subarch for arm.

These names in particular are used in ChromeOS, Android, and a few other
known applications. In ChromeOS, we encountered a bug where armv7a arch
was not recognised and segfaulted when starting an executable on an
arm32 device.

Recreating this cl:
get_patch.py -s HEAD 0a00d32c5f88fce89006dcde6e235bc77d7b495e

BUG=b:361414339
TEST=Ran with lldb-hana under qemu-arm

(cherry picked from commit a19a091eb14534ec05e14447677665111a635eaf)

Change-Id: I5af0f832bb657780232b59d8014133a25581ea2f
Original-Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5827378
Original-Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Original-Reviewed-by: Bob Haarman <inglorion@chromium.org>
Original-Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
GitOrigin-RevId: a19a091eb14534ec05e14447677665111a635eaf
Cr-Build-Id: 8735988028124072689
Cr-Build-Url:

https://cr-buildbucket.appspot.com/build/8735988028124072689
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5885669
Reviewed-by: Grzegorz Bernacki <bernacki@google.com>
Owners-Override: Aaron Massey <aaronmassey@google.com>
Tested-by: Jonathon Murphy <jpmurphy@google.com>

A dev-util/lldb-server/files/0a00d32c5f88fce89006dcde6e235bc77d7b495e.patch
M dev-util/lldb-server/files/PATCHES.json
M sys-devel/llvm/files/PATCHES.json
A sys-devel/llvm/files/cherry/0a00d32c5f88fce89006dcde6e235bc77d7b495e.patch

https://chromium-review.googlesource.com/5885669