SafeArgs failing for older Kotlin versions [190739257]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of lc...@gmail.com #1

Jun 10, 2021 07:04PM

When using Navigation SafeArgs 2.4.0-alpha01+ with Kotlin versions before 1.5.0, you get the following:

Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at

* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'

This is because the titleCase API was not added until Kotlin 1.5.0.

In 2.4.0-alpha01+, SafeArgs must be compatible with AGP 4.2.0 and as a result Gradle 6.7.0, which is compatible with Kotlin versions prior to 1.5.0.

We should avoid using titlecase in SafeArgs until we no longer need to support older Kotlin versions. As a workaround, you can update your gradle version to 7.0+.

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2021 10:27PM

I assume you were expecting it to bias towards the longer matching deep link?

Right now, it is greedy, avoiding the need to iterate through your entire graph. That means a valid workaround for the moment would be to swap the order of your destinations, which should put the first deep link first.

jb...@google.com <jb...@google.com> #3Jun 10, 2021 10:31PM

Marked as fixed.

Yes, exactly. I think most of the people would expect it to match longer deep link :)

Hmm... Do you think your solution is safe? It is totally based on implementation details, which could change in the next release. Plus I actually tested it and it doesn't work - I put exhibitorDetails on the top, but the behavior didn't change. I did a full clean of the project.

At the moment I look for deep link manually and I see if it contains "/exhibitors/{exhibitorId}". If it does, I redirect to the next view manually. Obviously, I hope it's gonna be fixed, as it looks ugly in my code, and I hate ugly code 😁 Do you think it's possible to include that bug in upcoming releases? I saw you're working on supporting query params in deep, that should be more or less same place in the project.

ma...@gmail.com <ma...@gmail.com> #4Nov 8, 2021 10:03AM

Yep, we'll fix it.

de...@atommobility.com <de...@atommobility.com> #5Nov 17, 2021 12:44PM

This has been fixed internally in

https://android-review.googlesource.com/870978 and will be available in Navigation 1.0.0-alpha10.

Navigation now biases selecting deep links based on the number of matching arguments (more matching arguments are considered better matches).

jb...@google.com <jb...@google.com> #6Nov 17, 2021 04:08PM

Please file a bug with a minimum sample project that reproduces this issue.

th...@gmail.com <th...@gmail.com> #7Jan 27, 2022 12:44PM

Hi Team,

Issue is still reproducible with Gradle 7.0

Please help to fix on priority

jb...@google.com <jb...@google.com> #8Jan 27, 2022 04:03PM