SafeArgs failing for older Kotlin versions [190739257]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of lc...@gmail.com #1

Jun 10, 2021 07:04PM

When using Navigation SafeArgs 2.4.0-alpha01+ with Kotlin versions before 1.5.0, you get the following:

Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at

* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'

This is because the titleCase API was not added until Kotlin 1.5.0.

In 2.4.0-alpha01+, SafeArgs must be compatible with AGP 4.2.0 and as a result Gradle 6.7.0, which is compatible with Kotlin versions prior to 1.5.0.

We should avoid using titlecase in SafeArgs until we no longer need to support older Kotlin versions. As a workaround, you can update your gradle version to 7.0+.

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2021 10:27PM

After creating the issue I've noticed that I mixed up a few terms, sorry about that. JobService should be JobScheduler. When referring to jobs in the description, those are classes extending Worker.

jb...@google.com <jb...@google.com> #3Jun 10, 2021 10:31PM

Marked as fixed.

We have a large set of users seeing this same issue... I can confirm that it seems to only effect users using Android OS 4.4 - 5.1. We are also using WorkManager 2.0.0

ma...@gmail.com <ma...@gmail.com> #4Nov 8, 2021 10:03AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 098c163581a360c32baa6e4c215227f0efd10889
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Mar 25 14:05:34 2019

Reset WorkConstraintsTracker when cleaning up in DelayMetCommandHandler.

* DelayMetCommandHandler would previously not cleanup correctly and WorkConstraintsTracker
would trigger callbacks without going through the SystemAlarmDispatcher lifecycle
of processing a command.

Fixes:

b/129226383

Test: Added a unit test.
Change-Id: Id2aaf0cce7c4a1a4526a25a211f3fe0551dbe557

M work/workmanager/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java

https://android-review.googlesource.com/933140

https://goto.google.com/android-sha1/098c163581a360c32baa6e4c215227f0efd10889

de...@atommobility.com <de...@atommobility.com> #5Nov 17, 2021 12:44PM

Great to see such a quick fix. Do you have any estimate when a new version that includes this change will be released?

jb...@google.com <jb...@google.com> #6Nov 17, 2021 04:08PM

It should be available in the next 2.x.x version.

th...@gmail.com <th...@gmail.com> #7Jan 27, 2022 12:44PM

ETA?

jb...@google.com <jb...@google.com> #8Jan 27, 2022 04:03PM

Hi, we have implemented a new big feature using WorkManager and got the same issue. We have been considering third party alternatives because we need to deliver this ASAP. But if you confirm that we will have that version within next few days we can wait for it.