SafeArgs failing for older Kotlin versions [190739257]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of lc...@gmail.com #1

Jun 10, 2021 07:04PM

When using Navigation SafeArgs 2.4.0-alpha01+ with Kotlin versions before 1.5.0, you get the following:

Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at

* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'

This is because the titleCase API was not added until Kotlin 1.5.0.

In 2.4.0-alpha01+, SafeArgs must be compatible with AGP 4.2.0 and as a result Gradle 6.7.0, which is compatible with Kotlin versions prior to 1.5.0.

We should avoid using titlecase in SafeArgs until we no longer need to support older Kotlin versions. As a workaround, you can update your gradle version to 7.0+.

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2021 10:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4fc8470745f5b0f08f9531b7ab85eed6a8f424cb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jun 10 11:26:54 2021

Remove uses of titleCase in Safe Args

The titleCase API was added in Kotlin 1.5.0. Gradle versions previous to
7.0 relied on eariler versionss of Kotlin that do not have that API
available. SafeArgs now depends on Android Gradle Plugin 4.2.0, which is
compatible down to Gradle 6.7.1, so we should continue to support older
versions of kotlin until we move to the next stable version of AGP.

RelNote: "SafeArgs will no longer fail when building your app with
`Kotlin` versions before `1.5.0`."
Test: tested in sample app
Bug: 190739257

Change-Id: Icd1ff3c64f220f4b310934c2edf910d6aae01475

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/String_ext.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavArgumentResolverTest.kt

https://android-review.googlesource.com/1733983

jb...@google.com <jb...@google.com> #3Jun 10, 2021 10:31PM

Marked as fixed.

This is fixed internally and will be available in the the Navigation 2.4.0-alpha04 release.

ma...@gmail.com <ma...@gmail.com> #4Nov 8, 2021 10:03AM

Still occurs in Version 2.4.0-beta02 with Gradle 6.9

de...@atommobility.com <de...@atommobility.com> #5Nov 17, 2021 12:44PM

Still occurs in Version 2.4.0-beta02 with Gradle 6.9

jb...@google.com <jb...@google.com> #6Nov 17, 2021 04:08PM

Please file a bug with a minimum sample project that reproduces this issue.

th...@gmail.com <th...@gmail.com> #7Jan 27, 2022 12:44PM

Hi Team,

Issue is still reproducible with Gradle 7.0

Please help to fix on priority

jb...@google.com <jb...@google.com> #8Jan 27, 2022 04:03PM