SafeArgs failing for older Kotlin versions [190739257]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of lc...@gmail.com #1

Jun 10, 2021 07:04PM

When using Navigation SafeArgs 2.4.0-alpha01+ with Kotlin versions before 1.5.0, you get the following:

Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at

* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'

This is because the titleCase API was not added until Kotlin 1.5.0.

In 2.4.0-alpha01+, SafeArgs must be compatible with AGP 4.2.0 and as a result Gradle 6.7.0, which is compatible with Kotlin versions prior to 1.5.0.

We should avoid using titlecase in SafeArgs until we no longer need to support older Kotlin versions. As a workaround, you can update your gradle version to 7.0+.

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2021 10:27PM

Can you give us the sample app or code that's exhibiting this problem?

jb...@google.com <jb...@google.com> #3Jun 10, 2021 10:31PM

Marked as fixed.

See sample app linked in

https://issuetracker.google.com/issues/134197846#comment52

In MyWorker.java, set `useInitialDelayForPeriodic` to `true`

ma...@gmail.com <ma...@gmail.com> #4Nov 8, 2021 10:03AM

Your examples have an initial delay + a flex time.
So the first instance will be closer to ~30 mins, because you want the periodic work to only be eligible at the end of initial delay + beginning of the flex window.

de...@atommobility.com <de...@atommobility.com> #5Nov 17, 2021 12:44PM

No, when `useInitialDelayForPeriodic` is set to `true`, I'm not using a flexInterval... check the code.

jb...@google.com <jb...@google.com> #6Nov 17, 2021 04:08PM

Sorry, i might have misread that part of the source code.

> BUT I'm not finding that. Let's say that "interval" of the periodic work is 15 mins, and I set an "initial delay" also of 15 mins, and I set this going when the user hits the button. I find that the immediate work is performed at 0 mins (triggered explicitly, not by WorkManager, so that's as expected), then at 15 mins NOTHING happens, and only at 30 mins does the first periodic work actually run.
What do you mean when you say - triggered work explicitly ? [ "I find that the immediate work is performed at 0 mins (triggered explicitly, not by WorkManager, so that's as expected)" ]

Which part of the source code are you referring to ?

th...@gmail.com <th...@gmail.com> #7Jan 27, 2022 12:44PM

MyWorker.java:

static void schedulePeriodicWork(Context context, int appWidgetId, String trigger) {

Log.d(TAG, "schedulePeriodicWork for " + appWidgetId);

// do an immediate update, with periodic work kicking in later (subject to Doze etc)
doSomeWork(context, appWidgetId);

^^^^^^
this bit is where I call doSomeWork() directly, when scheduling the periodic work, to get a guaranteed immediate execution of the first work.

jb...@google.com <jb...@google.com> #8Jan 27, 2022 04:03PM

Yeah.. I realized that's the part of the code that you were talking about. Your source code also had OneTimeWorkRequest's being created (but was not being called by anyone) - so was confused.