SafeArgs failing for older Kotlin versions [190739257]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of lc...@gmail.com #1

Jun 10, 2021 07:04PM

When using Navigation SafeArgs 2.4.0-alpha01+ with Kotlin versions before 1.5.0, you get the following:

Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at

* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'

This is because the titleCase API was not added until Kotlin 1.5.0.

In 2.4.0-alpha01+, SafeArgs must be compatible with AGP 4.2.0 and as a result Gradle 6.7.0, which is compatible with Kotlin versions prior to 1.5.0.

We should avoid using titlecase in SafeArgs until we no longer need to support older Kotlin versions. As a workaround, you can update your gradle version to 7.0+.

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2021 10:27PM

This has been fixed internally in

https://android-review.googlesource.com/870975 and will be available in Navigation 1.0.0-alpha10.

Now, instead of crashing, we ignore invalid deep links, printing a log message saying as much.

jb...@google.com <jb...@google.com> #3Jun 10, 2021 10:31PM

Marked as fixed.

Hi team.
The problem still occurs on version 2.2.0-rc04

ma...@gmail.com <ma...@gmail.com> #4Nov 8, 2021 10:03AM

Hi, still getting crash for 2.1.0

de...@atommobility.com <de...@atommobility.com> #5Nov 17, 2021 12:44PM

still getting crash on version 2.2.0

jb...@google.com <jb...@google.com> #6Nov 17, 2021 04:08PM

getting crash with 2.2.1

th...@gmail.com <th...@gmail.com> #7Jan 27, 2022 12:44PM

still getting crash with 2.2.1

jb...@google.com <jb...@google.com> #8Jan 27, 2022 04:03PM

findInvalidDestinationDisplayNameInDeepLink always return null if deepLink length == 1 (deep link destination is start destination of any navGraph of BottomNavigationView)

NavDestination node = i == 0 ? mGraph : graph.findNode(destinationId);
if deepLink.length == 1 node never will be null and this will cause IllegalStateException

Bug demo:

get NavigationAdvancedSample from github

on R.id.about_btn click

NavDeepLinkBuilder(it.context)
.setGraph(R.navigation.list)
.setDestination(R.id.leaderboard)
.createTaskStackBuilder()
.startActivities()

will crash because R.id.leaderboard is start destination (findInvalidDestinationDisplayNameInDeepLink will have deepLink length == 1)

NavDeepLinkBuilder(it.context)
.setGraph(R.navigation.list)
.setDestination(R.id.userProfile)
.createTaskStackBuilder()
.startActivities()

will work because findInvalidDestinationDisplayNameInDeepLink will return NOT null