Incorrect font weight are set for DownloadableFonts on API 29+ [194553426]

Fixed

Bug

Status Update

No update yet.

Description

ri...@gmail.com

created issue #1

Jul 24, 2021 01:22PM

Artifact used: androidx.core:core:1.6.0 Version used: 1.6.0 Theme used: (Not related) Devices/Android versions reproduced on: Pixel 5 Android 11

https://cs.android.com/androidx/platform/frameworks/support/+/c32cc6c885b20be94d2d1c0498e4a978161d3f61:core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java;l=131-136

final FontStyle defaultStyle = new FontStyle(
    (style & Typeface.BOLD) != 0 ? FontStyle.FONT_WEIGHT_BOLD
       : FontStyle.FONT_WEIGHT_NORMAL,
    (style & Typeface.ITALIC) != 0 ? FontStyle.FONT_SLANT_ITALIC
       : FontStyle.FONT_SLANT_UPRIGHT
);

return new Typeface.CustomFallbackBuilder(familyBuilder.build())
    .setStyle(defaultStyle)
    .build();

This part will make the final Typeface lost the correct font-weight from the FontInfo. For example, request for a font with 500 weight, but the final Typeface has 400 weight. This will make the fallback font incorrectly displayed.

The fix is to use the style from the best-matched font, just like the platform, https://cs.android.com/android/platform/superproject/+/android-11.0.0_r1:frameworks/base/graphics/java/android/graphics/Typeface.java;l=276-285.

Comments

ow...@google.com <ow...@google.com> Aug 2, 2021 01:07PM

Assigned to no...@google.com.

ri...@gmail.com <ri...@gmail.com> #2Aug 2, 2021 06:32PM

Can you explain your use case?

se...@google.com <se...@google.com> #3Mar 29, 2022 06:29PM

Reassigned to se...@google.com.

I can explain my one. I have a navhost fragment, where I load a graph with just one instance of a screen of acceptance of terms of use. After the approval of the user I load the real nav graph into the same navhost. According to the documentation The current data of the graph should be reset, so the new Navigation items can be reached. But unfortunately the new items from the graph cannot be reached.

ap...@google.com <ap...@google.com> #4Mar 30, 2022 08:38AM

Re #3 - that's not how you should be doing conditional navigation (see the documentation:

https://developer.android.com/topic/libraries/architecture/navigation/navigation-conditional), but we should take a closer look at this anyways.

lo...@gmail.com <lo...@gmail.com> #5Mar 30, 2022 08:59AM

Any updates on this issue?

Thanks

se...@google.com <se...@google.com> #6Mar 30, 2022 03:56PM

Navigation now pops all destinations off the back stack (if any exists) when you call setGraph().

This has been fixed internally in

https://android-review.googlesource.com/867951 and will be available in Navigation 1.0.0-alpha10

se...@google.com <se...@google.com> Jun 29, 2022 04:41PM

Marked as fixed.