Incorrect font weight are set for DownloadableFonts on API 29+ [194553426]

Fixed

Bug

Status Update

No update yet.

Description

ri...@gmail.com

created issue #1

Jul 24, 2021 01:22PM

Artifact used: androidx.core:core:1.6.0 Version used: 1.6.0 Theme used: (Not related) Devices/Android versions reproduced on: Pixel 5 Android 11

https://cs.android.com/androidx/platform/frameworks/support/+/c32cc6c885b20be94d2d1c0498e4a978161d3f61:core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java;l=131-136

final FontStyle defaultStyle = new FontStyle(
    (style & Typeface.BOLD) != 0 ? FontStyle.FONT_WEIGHT_BOLD
       : FontStyle.FONT_WEIGHT_NORMAL,
    (style & Typeface.ITALIC) != 0 ? FontStyle.FONT_SLANT_ITALIC
       : FontStyle.FONT_SLANT_UPRIGHT
);

return new Typeface.CustomFallbackBuilder(familyBuilder.build())
    .setStyle(defaultStyle)
    .build();

This part will make the final Typeface lost the correct font-weight from the FontInfo. For example, request for a font with 500 weight, but the final Typeface has 400 weight. This will make the fallback font incorrectly displayed.

The fix is to use the style from the best-matched font, just like the platform, https://cs.android.com/android/platform/superproject/+/android-11.0.0_r1:frameworks/base/graphics/java/android/graphics/Typeface.java;l=276-285.

Comments

ow...@google.com <ow...@google.com> Aug 2, 2021 01:07PM

Assigned to no...@google.com.

ri...@gmail.com <ri...@gmail.com> #2Aug 2, 2021 06:32PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

se...@google.com <se...@google.com> #3Mar 29, 2022 06:29PM

Reassigned to se...@google.com.

Thanks for the report!

ap...@google.com <ap...@google.com> #4Mar 30, 2022 08:38AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

lo...@gmail.com <lo...@gmail.com> #5Mar 30, 2022 08:59AM

deleted

se...@google.com <se...@google.com> #6Mar 30, 2022 03:56PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

se...@google.com <se...@google.com> Jun 29, 2022 04:41PM

Marked as fixed.