[AutoMigration] Migrating table with column "index" [197133152]

Fixed

Bug

Status Update

No update yet.

Description

ne...@gmail.com

created issue #1

Aug 19, 2021 07:30AM

Component

Component used:
- room-compiler
Version used:
- 2.4.0-alpha04
Devices/Android versions reproduced on:
- Runtime migration issue on every device / Emulator Android 12, Pixel 5

Description

Adding column name with SQL keyword makes the compiler fail to escape the keyword and thereafter fail to migrate the database.

I seem to be unable to escape this even with the RenameColumn and DeleteColumn as they seek the exact names and therefore will skip escaping with `.

Proposed Solution

Have the compiler escape SQL keywords in column and table names.

Code sample

Before:

@Entity(tableName = "foobar")
data class FooBar(
  // ...
  @ColumnInfo(name = "index") val position: Int
)

After:

@Entity(tableName = "foobar")
data class FooBar(
  // ...
  @ColumnInfo(name = "position") val position: Int
)

@RenameColumn.Entries(
  value = [
    RenameColumn(
      tableName = "foobar",
      fromColumnName = "index",
      toColumnName = "position"
    )
  ]
)
class MyMigrationSpec : AutoMigrationSpec

Comments

da...@google.com <da...@google.com> Aug 19, 2021 11:58AM

Reassigned to el...@google.com.

el...@google.com <el...@google.com> Oct 27, 2021 05:33PM

Marked as fixed.

ap...@google.com <ap...@google.com> #2Oct 27, 2021 05:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a071470cde57cf7eb6e39a67d331d716a0f8b842
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 15 14:01:37 2020

Add SpecialEffectsController infrastructure

"Special Effects" is the blanket term for
Animation, Animator, framework Transition, and
AndroidX Transition that Fragments currently support.

Add the infrastructure around a SpecialEffectsController
which would operate on the container (i.e., ViewGroup)
level and coordinate all of the special effects.

This will eventually allow us to track the
postponed state at the container level.

Currently all APIs are purposefully package private
as they should not be used by external developers
at this time.

BUG: 147749580
Test: new test suites pass
Change-Id: I1e209bb4f55c21aa01afb49035d41f5b8d7d3eca

A fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
A fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
A fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java
A fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsControllerFactory.java
M fragment/fragment/src/main/res/values/ids.xml
M jetifier/jetifier/migration.config

https://android-review.googlesource.com/1209367

Issue 197133152

Description

Component

Description

Proposed Solution

Code sample

Issue summary

Comments

da...@google.com <da...@google.com> Aug 19, 2021 11:58AM

el...@google.com <el...@google.com> Oct 27, 2021 05:33PM

ap...@google.com <ap...@google.com> #2Oct 27, 2021 05:34PM

Add comment

Issue metadata